Conversation
severo
changed the title
severo
force-pushed
the
accept-getcolumn-method
branch
from
6fdf6c6 to
5c991a1
Compare
severo
force-pushed
the
accept-getcolumn-method
branch
from
5c991a1 to
917c1bc
Compare
| * | ||
| * @returns Values in the column | ||
| */ | ||
| export type GetColumn = ({ column, start, end }: {column: string, start?: number, end?: number}) => Promise<any[]> |
There was a problem hiding this comment.
Eventually we may want to allow any[] OR TypedArrays as this will allow faster parsing from parquet. But I'd leave this as any[] for now, just making a note for the future.
There was a problem hiding this comment.
yes, exactly. As I mentioned here: #51 (comment), I chose this for now because hyparquet does not provide a way to get the TypedArrays (if I read correctly)
| // if orderBy is provided, start and end are applied to the sorted rows | ||
| rows(args: RowsArgs): AsyncRow[] | ||
| // negative start and end are allowed | ||
| rows({ start, end, orderBy }: {start: number, end: number, orderBy?: string}): AsyncRow[] |
There was a problem hiding this comment.
The types here should probably have whitespace between the curly braces. Wonder if there's a typescript eslint rule.
| rows({ start, end, orderBy }: {start: number, end: number, orderBy?: string}): AsyncRow[] | |
| rows({ start, end, orderBy }: { start: number, end: number, orderBy?: string }): AsyncRow[] |
There was a problem hiding this comment.
done.
Wonder if there's a typescript eslint rule.
Good question... I could look at it, maybe reopening hyparam/hyperparam-cli#35, if you want me to take time for this
2 participants
It will be used to compute the indexes of the sorted rows, to optimize the selection operations. See #34.
Reference discussion in #51