Skip to content

Change orderBy to an array#67

Merged
severo merged 4 commits intomasterfrom
enable-descending-order
Mar 11, 2025
Merged

Change orderBy to an array#67
severo merged 4 commits intomasterfrom
enable-descending-order

Conversation

@severo
Copy link
Copy Markdown
Contributor

@severo severo commented Mar 7, 2025

Change the OrderBy type to an array of objects: {column: string}[] (only the first element is used to sort, and always in ascending order)

@severo severo marked this pull request as draft March 7, 2025 17:08
@severo severo changed the title first step to change orderBy to an array Change orderBy to an array Mar 11, 2025
Comment thread src/HighTable.css
padding-left: 2px;
background-color: #f1f1f3;
}
.table thead th.orderby.ascending ::after {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding an "ascending" class to anticipate when descending will be supported

@severo severo marked this pull request as ready for review March 11, 2025 11:02
@severo severo merged commit a63b484 into master Mar 11, 2025
@severo severo deleted the enable-descending-order branch March 11, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant