Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table can now be ordered by a column in descending order. When clicking on a column header, we follow the cycle: none -> ascending -> descending -> none...
See #67 for a previous PR where I changed
orderBy: {column: string}toorderBy: {column: string}[]. In this PR, we change it again toorderBy: {column: string, direction: 'ascending' | 'descending'}[].Issue: #15
in comparison to #15 (comment), I decided that for now,
orderByhas to be an array, and it has to contain the two properties:columnanddirection. We might want to loosen these types later, but I'm not sure it's a good idea, as it creates more special cases, and is not really needed.(remaining, in another PR: sort by multiple columns)