[components] Give the component the time to update #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I ran the test CI multiple times because the test was flaky (I could not reproduce locally). The fix seems to work well. https://github.com/hyparam/hyperparam-cli/actions/runs/11722358256 |
severo
changed the title
severo
force-pushed
the
13-wait-for-component-to-update
branch
from
5d12532 to
c6aad76
Compare
platypii
approved these changes
Nov 7, 2024
Contributor
platypii
left a comment
platypii
left a comment
There was a problem hiding this comment.
Nice fix, I hate flaky tests 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://testing-library.com/docs/dom-testing-library/api-async#findby-queries
fixes #13