Skip to content

[components] Give the component the time to update #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
severo merged 1 commit into from
Nov 7, 2024
Merged

[components] Give the component the time to update #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/components/test/components/Folder.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ describe('Folder Component', () => {
vi.mocked(listFiles).mockResolvedValueOnce(mockFiles)
const folderKey = parseKey('')
assert(folderKey.kind === 'folder')
const { getByText } = render(<Folder folderKey={folderKey} />)
const { findByText, getByText } = render(<Folder folderKey={folderKey} />)

await waitFor(() => {expect(listFiles).toHaveBeenCalledWith('')})

expect(getByText('/')).toBeDefined()

const folderLink = getByText('folder1/')
const folderLink = await findByText('folder1/')
expect(folderLink.closest('a')?.getAttribute('href')).toBe('/files?key=folder1/')

expect(getByText('/')).toBeDefined()

const fileLink = getByText('file1.txt')
expect(fileLink.closest('a')?.getAttribute('href')).toBe('/files?key=file1.txt')
expect(getByText('8196')).toBeDefined()
Expand All @@ -51,23 +51,23 @@ describe('Folder Component', () => {
vi.mocked(listFiles).mockRejectedValue(new Error(errorMessage))
const folderKey = parseKey('test-prefix/')
assert(folderKey.kind === 'folder')
const { getByText, queryByText } = render(<Folder folderKey={folderKey} />)
const { findByText, queryByText } = render(<Folder folderKey={folderKey} />)

await waitFor(() => { expect(listFiles).toHaveBeenCalled() })

await findByText('Error: ' + errorMessage)
expect(queryByText('file1.txt')).toBeNull()
expect(queryByText('folder1/')).toBeNull()
expect(getByText('Error: ' + errorMessage)).toBeDefined()
})

it('renders breadcrumbs correctly', async () => {
vi.mocked(listFiles).mockResolvedValue(mockFiles)
const folderKey = parseKey('subdir1/subdir2/')
assert(folderKey.kind === 'folder')
const { getByText } = render(<Folder folderKey={folderKey} />)
const { findByText, getByText } = render(<Folder folderKey={folderKey} />)
await waitFor(() => { expect(listFiles).toHaveBeenCalled() })

const subdir1Link = getByText('subdir1/')
const subdir1Link = await findByText('subdir1/')
expect(subdir1Link.closest('a')?.getAttribute('href')).toBe('/files?key=subdir1/')

const subdir2Link = getByText('subdir2/')
Expand Down