fix(mv): always backfill dest series table and register metadata on MV create - #105
Merged
Conversation
…V create The destination series table was never populated when creating a materialized view without WITH BACKFILL, because the ClickHouse native series MV only fires on new INSERTs to the source series table â�� and known series are skipped by register_new_series(). This left the dest _series table empty, causing all tag values in the MV destination to resolve as empty strings via the LEFT JOIN. - Always run series backfill on MV creation regardless of WITH BACKFILL - Register resulting series and tag values in RocksDB after backfill - Add register_series_from_series_table() helper to sync chDB series rows - Add test verifying dest series metadata is seeded without fact backfill - Bump version to 0.8.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The destination series table was never populated when creating a materialized view without WITH BACKFILL, because the ClickHouse native series MV only fires on new INSERTs to the source series table � and known series are skipped by register_new_series(). This left the dest _series table empty, causing all tag values in the MV destination to resolve as empty strings via the LEFT JOIN.