fix: resolve 5 materialized view pipeline bugs - #55
Merged
Conversation
Bug C: MV SELECT field order: sort field expressions by output name in
translate_materialized_view_select so they match the destination table's
sorted-by-physical-name column order (ClickHouse INSERT is positional).
Bug D: Tag-field collision asymmetry: translate_materialized_view_series_select
now accepts an optional dest_field_names set, resolving tag physical column names
against the destination's field set rather than the source's.
Bug E: Raw-write guard: add materialized flag to MeasurementMeta. Set it on MV
destinations. reject_table rejects direct writes to materialized destinations.
Bug G: Orphaned table cleanup: drop_mv now calls drop_measurement on the
destination fact+series tables after dropping ClickHouse MV objects.
Bug 6: DROP MEASUREMENT RP support: change DropMeasurement AST from a bare
String to { name, rp: Option<String> }. Parser handles "rp"."measurement"
syntax. Handler uses RP when specified, default RP otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug C: MV SELECT field order: sort field expressions by output name in translate_materialized_view_select so they match the destination table's sorted-by-physical-name column order (ClickHouse INSERT is positional).
Bug D: Tag-field collision asymmetry: translate_materialized_view_series_select now accepts an optional dest_field_names set, resolving tag physical column names against the destination's field set rather than the source's.
Bug E: Raw-write guard: add materialized flag to MeasurementMeta. Set it on MV destinations. reject_table rejects direct writes to materialized destinations.
Bug G: Orphaned table cleanup: drop_mv now calls drop_measurement on the destination fact+series tables after dropping ClickHouse MV objects.
Bug 6: DROP MEASUREMENT RP support: change DropMeasurement AST from a bare String to { name, rp: Option }. Parser handles "rp"."measurement" syntax. Handler uses RP when specified, default RP otherwise.