Skip to content

P1: fix(auth): clear email when returning from OTP entry - #215

Merged
aspiers merged 1 commit into
mainfrom
split-pr165/clear-email-on-back
Jul 30, 2026
Merged

P1: fix(auth): clear email when returning from OTP entry#215
aspiers merged 1 commit into
mainfrom
split-pr165/clear-email-on-back

Conversation

@aspiers

@aspiers aspiers commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Make Use different email start from a clean email field rather than retaining the previous account. The field is cleared and focused so the next keystroke goes to the intended place.

Changes

  • Clear and focus the email field when returning from the OTP step
  • Cover the behavior with unit and Cucumber assertions

Testing

  • pnpm format:check
  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm test:coverage

Screenshots

Before: Use different email returned to a form that retained the previous address.

Before: email address retained

After: the form returns with a blank, focused email field.

After: cleared email form

Notes

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
epds-demo Ready Ready Preview Jul 30, 2026 3:40pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1a90062

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aspiers, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5be03abb-ef51-4592-adba-4c1a83f71b97

📥 Commits

Reviewing files that changed from the base of the PR and between 7bce175 and 1a90062.

📒 Files selected for processing (4)
  • .changeset/use-different-email-clears-form.md
  • e2e/step-definitions/auth.steps.ts
  • features/passwordless-authentication.feature
  • packages/auth-service/src/routes/login-page.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@railway-app

railway-app Bot commented Jul 30, 2026

Copy link
Copy Markdown

🚅 Deployed to the ePDS-pr-215 environment in ePDS

Service Status Web Updated (UTC)
@certified-app/pds-core ✅ Success (View Logs) Web Jul 30, 2026 at 4:10 pm
@certified-app/demo ✅ Success (View Logs) Web Jul 30, 2026 at 4:10 pm
@certified-app/demo untrusted ✅ Success (View Logs) Web Jul 30, 2026 at 3:53 pm
@certified-app/auth-service ✅ Success (View Logs) Web Jul 30, 2026 at 3:51 pm

@coveralls-official

coveralls-official Bot commented Jul 30, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 30557764696

Coverage remained the same at 57.281%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3069
Covered Lines: 1753
Line Coverage: 57.12%
Relevant Branches: 1910
Covered Branches: 1099
Branch Coverage: 57.54%
Branches in Coverage %: Yes
Coverage Strength: 6.06 hits per line

💛 - Coveralls

@aspiers aspiers changed the title fix(auth): clear email when returning from OTP entry P1: fix(auth): clear email when returning from OTP entry Jul 30, 2026
@aspiers

aspiers commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

The PR-attached E2E check is red only because its SHA-specific Railway deployment lookup timed out before the preview deployment was discoverable. The same commit passed the full deployed suite when run explicitly against ePDS / ePDS-pr-215: https://github.com/hypercerts-org/ePDS/actions/runs/30549079555

Comment thread packages/auth-service/src/__tests__/login-page.test.ts Outdated
@aspiers
aspiers force-pushed the split-pr165/clear-email-on-back branch from f3648cf to 1a90062 Compare July 30, 2026 15:39
@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-215 July 30, 2026 15:40 Destroyed
@sonarqubecloud

Copy link
Copy Markdown

@aspiers
aspiers marked this pull request as ready for review July 30, 2026 21:31
Copilot AI review requested due to automatic review settings July 30, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aspiers

aspiers commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@aspiers
aspiers merged commit e3cd4e9 into main Jul 30, 2026
31 of 32 checks passed
@aspiers
aspiers deleted the split-pr165/clear-email-on-back branch July 30, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants