P1: fix(auth): use truthful unavailable-handle copy by aspiers · Pull Request #227 · hypercerts-org/ePDS

aspiers · 2026-07-30T13:38:29Z

Summary

Describe rejected handles as unavailable rather than always claiming that another user already took them. This keeps the UI truthful for reserved names and other policy rejections.

Changes

Normalize live-check and submit-time copy to Not available
Add focused handle-picker render coverage
Document the end-user change with a changeset

Testing

pnpm format:check
pnpm lint
pnpm typecheck
pnpm test
pnpm test:coverage

Screenshots

Before: the unavailable state overclaimed that the handle was already taken.

After: it uses truthful generic copy. The preview responses were controlled to isolate both wording states.

Notes

Focused extraction and review of work originally proposed in [WIP] many usability fixes (needs untangling) #165.
The reserved-handle availability PR is stacked on this branch.

Summary by CodeRabbit

Bug Fixes
- Updated handle picker messaging to clearly state “Not available.” for reserved or unavailable handles.
- Removed misleading “Already taken” wording when a handle is permanently unavailable.
- Unavailable handle states now display consistently across themed interfaces.
Tests
- Added automated coverage verifying the updated availability message and preventing incorrect wording from appearing.

vercel · 2026-07-30T13:38:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
epds-demo	Ready	Preview	Jul 31, 2026 8:38am

changeset-bot · 2026-07-30T13:38:34Z

🦋 Changeset detected

Latest commit: 797bcd1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-07-30T13:38:38Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c16cb551-1f7a-440b-8cf6-f9216968acf3

📥 Commits

Reviewing files that changed from the base of the PR and between 68b0760 and 797bcd1.

📒 Files selected for processing (2)

packages/auth-service/src/routes/choose-handle.ts
packages/demo/src/lib/theme.ts

🚧 Files skipped from review as they are similar to previous changes (1)

packages/auth-service/src/routes/choose-handle.ts

📝 Walkthrough

Walkthrough

Handle-picker messaging now consistently reports unavailable handles as “Not available.” instead of “Already taken.” Server-rendered and client-side text, styling, the changeset, and end-to-end coverage are updated.

Changes

Handle availability messaging

Layer / File(s)	Summary
Update unavailable-handle messages `packages/auth-service/src/routes/choose-handle.ts`, `packages/demo/src/lib/theme.ts`, `.changeset/handle-not-available-message.md`	Server-rendered and client-side messages now use “Not available.” wording. The status class is `unavailable`, and the theme targets the new class. The changeset documents the correction.
Add unavailable-handle end-to-end coverage `e2e/step-definitions/handle-availability.steps.ts`, `features/handle-availability.feature`	Cucumber/Playwright steps stub an unavailable handle response and verify that “Not available.” is shown while “Already taken.” is absent.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change to use truthful copy for unavailable handles.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch split-pr165/handle-unavailable-copy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

railway-app · 2026-07-30T13:39:11Z

🚅 Deployed to the ePDS-pr-227 environment in ePDS

Service	Status	Web	Updated (UTC)
@certified-app/auth-service	✅ Success (View Logs)	Web	Jul 31, 2026 at 8:40 am
@certified-app/demo	✅ Success (View Logs)	Web	Jul 31, 2026 at 8:38 am
@certified-app/demo untrusted	✅ Success (View Logs)	Web	Jul 31, 2026 at 8:38 am
@certified-app/pds-core	✅ Success (View Logs)	Web	Jul 30, 2026 at 4:02 pm

coveralls-official · 2026-07-30T13:40:50Z

Coverage Report for CI Build 30616972439

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 57.281%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
3 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
packages/auth-service/src/routes/account-login.ts	3	0.0%

Coverage Stats


Relevant Lines:	3069
Covered Lines:	1753
Line Coverage:	57.12%
Relevant Branches:	1910
Covered Branches:	1099
Branch Coverage:	57.54%
Branches in Coverage %:	Yes
Coverage Strength:	6.06 hits per line

💛 - Coveralls

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

aspiers · 2026-07-30T21:36:28Z

@coderabbitai review

coderabbitai · 2026-07-30T21:36:34Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

The handle picker now reports unavailable results accurately, but its CSS class and demo theme override still used taken terminology. Rename the selector, call site, and related comments so reserved or policy-rejected handles are not described as claimed. Co-authored-by: OpenAI <noreply@openai.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sonarqubecloud · 2026-07-31T08:38:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vercel Bot deployed to Preview July 30, 2026 13:38 View deployment

railway-app Bot temporarily deployed to ePDS / ePDS-pr-227 July 30, 2026 13:39 Destroyed

aspiers changed the title ~~fix(auth): use truthful unavailable-handle copy~~ P1: fix(auth): use truthful unavailable-handle copy Jul 30, 2026

aspiers mentioned this pull request Jul 30, 2026

P1: fix(pds): reject reserved handles in live checks #228

Draft

aspiers marked this pull request as ready for review July 30, 2026 15:05

Copilot AI review requested due to automatic review settings July 30, 2026 15:05

Copilot AI reviewed Jul 30, 2026

fix(auth): use truthful unavailable-handle copy

68b0760

aspiers force-pushed the split-pr165/handle-unavailable-copy branch from b9b5803 to 68b0760 Compare July 30, 2026 15:39

Copilot AI review requested due to automatic review settings July 30, 2026 15:39

Copilot AI reviewed Jul 30, 2026

vercel Bot deployed to Preview July 30, 2026 15:40 View deployment

railway-app Bot temporarily deployed to ePDS / ePDS-pr-227 July 30, 2026 15:54 Destroyed

aspiers commented Jul 30, 2026

View reviewed changes

Comment thread packages/auth-service/src/routes/choose-handle.ts Outdated

Copilot AI review requested due to automatic review settings July 31, 2026 08:37

railway-app Bot temporarily deployed to ePDS / ePDS-pr-227 July 31, 2026 08:37 Destroyed

Copilot AI reviewed Jul 31, 2026

vercel Bot deployed to Preview July 31, 2026 08:38 View deployment

coderabbitai Bot mentioned this pull request Jul 31, 2026

P0: fix(a11y): announce authentication errors #224

Merged

aspiers merged commit 47b05d4 into main Jul 31, 2026
28 checks passed

aspiers deleted the split-pr165/handle-unavailable-copy branch July 31, 2026 21:44

Navigation Menu

Uh oh!

P1: fix(auth): use truthful unavailable-handle copy - #227

P1: fix(auth): use truthful unavailable-handle copy#227
aspiers merged 2 commits into
mainfrom
split-pr165/handle-unavailable-copy

aspiers commented Jul 30, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

railway-app Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

coveralls-official Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

aspiers commented Jul 30, 2026

Uh oh!

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

aspiers commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Testing

Screenshots

Notes

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

railway-app Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls-official Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 30616972439

Coverage remained the same at 57.281%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aspiers commented Jul 30, 2026

Uh oh!

coderabbitai Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 31, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aspiers commented Jul 30, 2026 •

edited

Loading

vercel Bot commented Jul 30, 2026 •

edited

Loading

changeset-bot Bot commented Jul 30, 2026 •

edited

Loading

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

railway-app Bot commented Jul 30, 2026 •

edited

Loading

coveralls-official Bot commented Jul 30, 2026 •

edited

Loading

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading