Skip to content

docs(skill): capitalize the word after a changeset audience label - #235

Merged
aspiers merged 2 commits into
mainfrom
docs/changeset-capitalization-rule
Aug 4, 2026
Merged

docs(skill): capitalize the word after a changeset audience label#235
aspiers merged 2 commits into
mainfrom
docs/changeset-capitalization-rule

Conversation

@aspiers

@aspiers aspiers commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The writing-changesets skill didn't state that the sentence after a bold **Audience:** label must start with a capital letter — the colon is a lead-in, not a mid-sentence break. Its own examples were inconsistent (some lowercase openers).

Changes:

  • Add an explicit rule under the per-audience-detail section with ✅/❌ examples.
  • Cover the awkward case where the first word is a lowercase code identifier: reword so it isn't sentence-initial (e.g. "The email_verified claim …", not "email_verified is now …").
  • Note the rule applies per-bullet when a section is a bullet list.
  • Fix the three lowercase openers in the skill's own example changesets (twoTwo, noNo ×2).

Prompted by review feedback on #234's changeset (apps/the/deployApps/The/Deploy); those suggestions are applied to #234 separately.

🤖 Generated with Claude Code

… label

The writing-changesets skill didn't state that the sentence after a bold
`**Audience:**` label must start with a capital letter, and its own examples
were inconsistent (some lowercase). Add an explicit rule with ✅/❌ examples,
including the identifier-initial case (reword so a lowercase code identifier
isn't sentence-initial), and fix the three lowercase openers in the skill's
own example changesets.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 4, 2026 14:19
@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0254619

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
epds-demo Ready Ready Preview Aug 4, 2026 9:22pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aspiers, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 387b71f9-d18a-4b5e-be6f-2f7cdcfa08c0

📥 Commits

Reviewing files that changed from the base of the PR and between d2736c3 and 0254619.

📒 Files selected for processing (1)
  • .agents/skills/writing-changesets/SKILL.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@railway-app

railway-app Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚅 Deployed to the ePDS-pr-235 environment in ePDS

Service Status Web Updated (UTC)
@certified-app/demo untrusted ✅ Success (View Logs) Web Aug 4, 2026 at 2:21 pm
@certified-app/auth-service ✅ Success (View Logs) Web Aug 4, 2026 at 2:21 pm
@certified-app/demo ✅ Success (View Logs) Web Aug 4, 2026 at 2:21 pm
@certified-app/pds-core ✅ Success (View Logs) Web Aug 4, 2026 at 2:20 pm

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the writing-changesets agent skill documentation to make per-audience prose style consistent by requiring capitalization immediately after audience labels, with examples and guidance for awkward identifier-led sentences.

Changes:

  • Adds an explicit “capitalize after audience label” rule with ✅/❌ examples, including guidance for lowercase code identifiers.
  • Clarifies that the capitalization rule applies per bullet when per-audience details are written as bullet lists.
  • Fixes lowercase sentence starters in the skill’s own example changesets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/skills/writing-changesets/SKILL.md Outdated
@coveralls-official

coveralls-official Bot commented Aug 4, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 30952044983

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.2%) to 57.909%

Details

  • Coverage increased (+0.2%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 51 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

51 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
packages/auth-service/src/routes/preview.ts 41 0.0%
packages/shared/src/client-metadata.ts 7 82.35%
packages/auth-service/src/routes/account-login.ts 3 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 3106
Covered Lines: 1789
Line Coverage: 57.6%
Relevant Branches: 1945
Covered Branches: 1136
Branch Coverage: 58.41%
Branches in Coverage %: Yes
Coverage Strength: 9.78 hits per line

💛 - Coveralls

Two fixes to the capitalization rule added in d897e61.

The rule referred to a literal `**Audience:**` label, which does not
exist — the real labels are `**End users:**`, `**Client app
developers:**` and `**Operators:**`. A reader could reasonably have
taken `**Audience:**` for a valid label. Name two real ones instead.

The paragraph also carried a blank line before its bullet list, which
`prettier --check` rejected and which is inconsistent with the two
other nested bullet lists in this file (neither has one).

Raised by Copilot in review of #235.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 4, 2026 21:22
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@aspiers
aspiers merged commit 03a13da into main Aug 4, 2026
21 checks passed
@aspiers
aspiers deleted the docs/changeset-capitalization-rule branch August 4, 2026 21:25
@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-235 August 4, 2026 21:26 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants