Skip to content

Conversation

@brandon-pereira
Copy link
Member

@brandon-pereira brandon-pereira commented Oct 28, 2025

Ensures Date Picker and Selects under TimePicker can be accessed.

Before

When trying to click a date in the TimePicker it would close the modal (due to click outside)

After

Modal will remain open and interactive as expected

Fixes HDX-2662

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2025

🦋 Changeset detected

Latest commit: b0110cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 29, 2025 2:59pm

@claude
Copy link

claude bot commented Oct 28, 2025

Code Review

No critical issues found.

The changes correctly fix the modal closing bug by:

  • Using a portal approach to render nested popovers within the same container
  • Properly managing the container ref with useState to ensure rerenders
  • Applying popoverProps to DateInput components and comboboxProps to Select

Minor observations (non-blocking):

  • Implementation follows React best practices with proper hooks usage
  • useMemo correctly optimizes the dateComponentPopoverProps object
  • The fix is minimal and focused on the specific issue

Ready to merge once CI passes.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

E2E Test Results

All tests passed • 26 passed • 3 skipped • 209s

Status Count
✅ Passed 26
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

Copy link
Contributor

@pulpdrew pulpdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@kodiakhq kodiakhq bot merged commit 808413f into main Oct 29, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the brandon/fix-timepicker-popovers branch October 29, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants