Skip to content

Conversation

@brandon-pereira
Copy link
Member

Small improvements to heatmap logic:

  1. Improve the logic around filtering the outliers. Previously it was hardcoded to Duration, now it will correctly use the Value from the user. If the value contains an aggregate function, it will also perform a CTE to properly calculate.
  2. If the outliers query fails, we show the user the query error
  3. We prioritize the outlier keys in the event deltas view over inliers (this was how it was before, now it only includes inliers if no outliers are found)
  4. Ensure the autocomplete suggestions are displayed (there was a zindex issue)

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

🦋 Changeset detected

Latest commit: fb64c77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 4, 2025 9:48pm

@claude
Copy link

claude bot commented Oct 30, 2025

PR Review

Critical Issues

  • 🔒 SQL Injection Risk in DBDeltaChart.tsx:300-305, 316 → User-controlled values xMin, xMax, yMin, yMax, and valueExpr are directly interpolated into SQL conditions without sanitization. These should be parameterized queries or validated/escaped.

Important Issues

  • ⚠️ Inconsistent type casting in DBDeltaChart.tsx:298-312 → The type: config.whereLanguage cast may be unsafe if whereLanguage is not a valid Filter type. Should validate or use proper typing.

  • ⚠️ Missing validation in DBSearchHeatmapChart.tsx:99 → The coordinates from URL params (xMin, xMax, yMin, yMax) are used without validation. Add bounds checking before passing to DBDeltaChart.

  • ⚠️ Incomplete type annotation in DBDeltaChart.tsx:311 → Uses as Filter instead of satisfies Filter (inconsistent with lines 301-302, 304-305). Should use consistent type assertion pattern.

Code Quality

  • 📝 Large function in DBDeltaChart.tsx → The component has grown significantly with nested helper functions. Consider extracting buildAggregatedTimestampsCTE, buildWithClauses, and buildFilters to separate utilities for better testability.

✅ Tests added for HAVING clause functionality look comprehensive.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

E2E Test Results

All tests passed • 39 passed • 3 skipped • 301s

Status Count
✅ Passed 39
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@brandon-pereira brandon-pereira marked this pull request as ready for review October 31, 2025 16:16
@brandon-pereira brandon-pereira requested review from a team and pulpdrew and removed request for a team October 31, 2025 16:17
Copy link
Contributor

@pulpdrew pulpdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 8dee21c into main Nov 4, 2025
8 of 9 checks passed
@kodiakhq kodiakhq bot deleted the brandon/heatmap-improvements branch November 4, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants