-
Notifications
You must be signed in to change notification settings - Fork 323
Minor Heatmap Improvements #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fb64c77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR ReviewCritical Issues
Important Issues
Code Quality
✅ Tests added for HAVING clause functionality look comprehensive. |
E2E Test Results✅ All tests passed • 39 passed • 3 skipped • 301s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Small improvements to heatmap logic:
Valuefrom the user. If the value contains an aggregate function, it will also perform a CTE to properly calculate.