chore: Update to next 16, react 19, add react compiler by teeohhem · Pull Request #1434 · hyperdxio/hyperdx

teeohhem · 2025-12-03T14:22:35Z

fixes: HDX-2956

changeset-bot · 2025-12-03T14:22:39Z

🦋 Changeset detected

Latest commit: 5801169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/common-utils	Minor
@hyperdx/api	Minor
@hyperdx/app	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-12-03T14:22:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
hyperdx-v2-oss-app	Ready	Preview	Comment	Dec 4, 2025 11:40pm

claude · 2025-12-03T14:24:21Z

PR Review: Next.js 16, React 19, React Compiler Upgrade

Critical Issues

❌ Logic bug in MetricNameSelect.tsx:153 → Condition !metricsFromQuery.find(metric => metric.value !== ...) is inverted - should be === not !==. This breaks saved metric fallback logic when metric is not in query results.

Important Issues

⚠️ Next.js config spreading anti-pattern (next.config.mjs:60) → Spreading withNextra() into nextConfig breaks config merge - move headers/output into nextConfig directly
⚠️ React Compiler escape hatch with TODO (TableHeader.tsx:23) → "use no memo" disables compiler optimization with vague TODO - document specific resize bug or file issue
⚠️ useWatch performance concern (DBEditTimeChartForm.tsx) → Multiple useWatch calls (4+ per series) may cause excessive re-renders - commit message claims this fixes re-render bug but does not explain how

Questions

Node version bump (.nvmrc) - does CI/Docker use this version?
Is Turbopack webpack workaround (package.json scripts) still needed after CSS fixes?

Summary: 1 critical logic bug, 1 config anti-pattern, rest are documentation/performance concerns.

github-actions · 2025-12-03T14:31:04Z

E2E Test Results

✅ All tests passed • 45 passed • 3 skipped • 361s

Status	Count
✅ Passed	45
❌ Failed	0
⚠️ Flaky	1
⏭️ Skipped	3

View full report →

teeohhem · 2025-12-03T14:47:01Z

  },
-  async down(db: Db, client: MongoClient) {
+  async down(db: Db, _client: MongoClient) {
    await db.collection('users').updateMany({}, { $unset: { accessKey: '' } });


new version of eslint - linting fixes

teeohhem · 2025-12-03T14:47:18Z

-node_modules
-archive
-migrate-mongo-config.ts
-jest.setup.ts


package deprecated in eslint 9. Ignores moved to main config file

teeohhem · 2025-12-03T14:47:57Z

-    'simple-import-sort/imports': 'error',
-    'simple-import-sort/exports': 'error',
-  },
-};


deprecated config file format. I moved this to new standard flat .mjs file

teeohhem · 2025-12-03T14:48:39Z

-      },
-    },
-  ],
-};


deprecated config file format. I moved this to new standard flat .mjs file

teeohhem · 2025-12-03T14:48:50Z

-        }
-      : {}),
-  }),
-};


deprecated config file format. I moved this to new standard flat .mjs file

teeohhem · 2025-12-03T14:49:28Z

-    "build": "next build",
+    "dev": "npx dotenv -e .env.development -- next dev --webpack",
+    "dev:local": "NEXT_PUBLIC_IS_LOCAL_MODE=true npx dotenv -e .env.development -- next dev --webpack",
+    "build": "next build --webpack",


really want us to use the new turbopack build, but there are issues with some of the css and its compilation inside of ts. Will create a follow up ticket

teeohhem · 2025-12-03T14:50:59Z

    "packages/api/src/routers/external-api/**/*.ts": [
      "prettier --write --ignore-unknown",
-      "eslint --fix --quiet",
+      "eslint --flag v10_config_lookup_from_file --fix --quiet",


eslint 9 changed how config files are discovered. If there wasn't a root config file in a mono repo, lint commands won't work. They added a flag to revert to old eslint behavior and plan to make it the default again in eslint10.

eslint/eslint#18574

teeohhem · 2025-12-03T14:53:15Z

+const basePath = process.env.NEXT_PUBLIC_HYPERDX_BASE_PATH;
+
+const nextConfig = {
+  reactCompiler: true,


enables react compiler. It will optimize things that would benefit from being memo'ed or wrapped in callbacks. You can see what it's doing if you use react devtools.

There is additional logging I can add in a future ticket. This new logging will output which components cannot be optimized and help us fix them manually.

new vulnerability patch

brandon-pereira · 2025-12-04T17:25:27Z

Tested and things LGTM - Did a general test of the app and didn't observe any issues.

we use pages router, which is client by default. Unnecessary

…om/next-update

teeohhem · 2025-12-04T18:29:08Z

Addressing the claude code review inline:

Critical Issues
❌ React Compiler not configured → Add Babel plugin configuration
The PR adds babel-plugin-react-compiler to dependencies and sets reactCompiler: true in next.config.mjs, but there's no babel.config.js or Next.js compiler configuration to actually enable the React Compiler. This means the flag is enabled but the compiler won't run.

You do not need babel configured for this to run. It uses the nextjs integration.

Important Issues
⚠️ Breaking change: publicRuntimeConfig removed → Verify all consumers updated
The old publicRuntimeConfig.version was replaced with NEXT_PUBLIC_APP_VERSION env var. While AppNav.tsx was updated, ensure no other code or external consumers rely on getConfig().publicRuntimeConfig.version.

⚠️ instrumentationHook removed without replacement → Verify OTel instrumentation still works
The experimental.instrumentationHook: true config was removed entirely. This may break OpenTelemetry instrumentation if it relied on this hook.

publicRuntimeConfig was removed and we now use the env config
instrumentationHook is now on by default

brandon-pereira · 2025-12-04T19:57:45Z

@teeohhem a couple other things:

Go to chart explorer (http://localhost:8080/chart?source=68b75158610c5e72acb01460&where=&select=&whereLanguage=lucene&orderBy=&config={%22name%22:%22%22,%22select%22:[{%22aggFn%22:%22quantile%22,%22aggCondition%22:%22%22,%22aggConditionLanguage%22:%22lucene%22,%22valueExpression%22:%22Duration%22,%22level%22:0.5}],%22where%22:%22%22,%22whereLanguage%22:%22lucene%22,%22displayType%22:%22line%22,%22granularity%22:%22auto%22,%22source%22:%22690539ea5ab5f5289adc29de%22,%22groupBy%22:%22ServiceName%22}), use Demo Traces. You'll see results.. then click "Search" and observe error:

Not sure if we want to run this codemod, or make a ticket for this deprecation warning:

When resizing the search page, it has substantial lag. I wonder if its some automemoized issue? Other pages like Services don't have this issue.

reszing.mov

fixes issue where it needed a full re-render in order to show the sql column field

brandon-pereira

Changes look good, we can open another ticket for the legacyBehavior issue

fixes: HDX-2956 Co-authored-by: Brandon Pereira <7552738+brandon-pereira@users.noreply.github.com>

vercel Bot deployed to Preview December 3, 2025 14:23 View deployment

teeohhem changed the title ~~chore: Update to next 15, react 19, add react compiler.~~ chore: Update to next 16, react 19, add react compiler. Dec 3, 2025

vercel Bot deployed to Preview December 3, 2025 14:35 View deployment

vercel Bot deployed to Preview December 3, 2025 14:39 View deployment

teeohhem changed the title ~~chore: Update to next 16, react 19, add react compiler.~~ chore: Update to next 16, react 19, add react compiler Dec 3, 2025

teeohhem commented Dec 3, 2025

View reviewed changes

vercel Bot deployed to Preview December 3, 2025 14:47 View deployment

teeohhem commented Dec 3, 2025

View reviewed changes

vercel Bot deployed to Preview December 3, 2025 21:03 View deployment

teeohhem force-pushed the tom/next-update branch from 068a5fc to 8e404d2 Compare December 3, 2025 21:06

vercel Bot deployed to Preview December 3, 2025 21:09 View deployment

teeohhem force-pushed the tom/next-update branch from 8e404d2 to a762712 Compare December 3, 2025 21:16

vercel Bot deployed to Preview December 3, 2025 21:19 View deployment

teeohhem added 2 commits December 3, 2025 16:25

chore: update to latest react/next.js

9b19dee

update next version

f07d2d3

new vulnerability patch

teeohhem force-pushed the tom/next-update branch from a762712 to f07d2d3 Compare December 3, 2025 21:27

vercel Bot deployed to Preview December 3, 2025 21:31 View deployment

fix: empty select bug + upgrade packages to latest patch

d58ee75

vercel Bot deployed to Preview December 4, 2025 16:37 View deployment

pr feedback

1697e51

update build files

0c98527

brandon-pereira previously approved these changes Dec 4, 2025

View reviewed changes

teeohhem marked this pull request as draft December 4, 2025 17:26

teeohhem added 3 commits December 4, 2025 12:39

undo client hooks

ca817a9

we use pages router, which is client by default. Unnecessary

build updates

bb8aafc

Merge branch 'tom/next-update' of github.com:hyperdxio/hyperdx into t…

37b2409

…om/next-update

teeohhem dismissed brandon-pereira’s stale review via 37b2409 December 4, 2025 18:05

vercel Bot deployed to Preview December 4, 2025 18:09 View deployment

teeohhem marked this pull request as ready for review December 4, 2025 18:17

teeohhem requested a review from brandon-pereira December 4, 2025 18:33

fix: rendering error on services page

cb38b87

vercel Bot deployed to Preview December 4, 2025 18:48 View deployment

brandon-pereira mentioned this pull request Dec 4, 2025

Fix font rendering issue #1448

Merged

teeohhem added 2 commits December 4, 2025 15:35

useWatch hook in dbedittimeform

6744f1a

fixes issue where it needed a full re-render in order to show the sql column field

fix: chart -> search error

7360bc2

vercel Bot deployed to Preview December 4, 2025 21:52 View deployment

fix: table headers use no memo directive

9bbb9ea

vercel Bot deployed to Preview December 4, 2025 22:41 View deployment

add comment

2ef945c

vercel Bot deployed to Preview December 4, 2025 22:44 View deployment

brandon-pereira approved these changes Dec 4, 2025

View reviewed changes

teeohhem added the automerge label Dec 4, 2025

Merge branch 'main' into tom/next-update

5801169

vercel Bot deployed to Preview December 4, 2025 23:40 View deployment

kodiakhq Bot merged commit 52d2798 into main Dec 4, 2025
9 checks passed

kodiakhq Bot deleted the tom/next-update branch December 4, 2025 23:41

knudtty pushed a commit that referenced this pull request Apr 16, 2026

chore: Update to next 16, react 19, add react compiler (#1434)

b2eb9a4

fixes: HDX-2956 Co-authored-by: Brandon Pereira <7552738+brandon-pereira@users.noreply.github.com>

Conversation

teeohhem commented Dec 3, 2025

Uh oh!

changeset-bot Bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude Bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: Next.js 16, React 19, React Compiler Upgrade

Critical Issues

Important Issues

Questions

Uh oh!

github-actions Bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brandon-pereira commented Dec 4, 2025

Uh oh!

teeohhem commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandon-pereira commented Dec 4, 2025

Uh oh!

brandon-pereira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Dec 3, 2025 •

edited

Loading

vercel Bot commented Dec 3, 2025 •

edited

Loading

claude Bot commented Dec 3, 2025 •

edited

Loading

github-actions Bot commented Dec 3, 2025 •

edited

Loading

teeohhem commented Dec 4, 2025 •

edited

Loading