fix: lagginess on search page and in sql input typing

[knudtty]

Still seems somewhat present but noticeably better. Profiler shows a great reduction

[changeset-bot]

⚠️ No Changeset found

Latest commit: 53329e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
hyperdx-v2-oss-app	Ready	Preview, Comment	Dec 19, 2025 5:46pm

[claude]

PR Review: Fix lagginess on search page

Performance Optimizations ✅

Good approach using useWatch instead of watch to reduce re-renders. The component extraction and memoization strategy is sound.

Issues Found

• ⚠️ Inconsistent memoization in DBSearchPage.tsx:548 → SaveSearchModal is memoized but its props are not stable (callbacks like onClose recreated every render). Either remove memo or wrap callbacks in useCallback

• ⚠️ Unnecessary memo on simple components → SearchSubmitButton, ResumeLiveTailButton, SourceEditMenu, SourceEditModal, NewSourceModal do not have expensive computations or child trees. Remove memo unless profiler shows benefit

• ❌ Breaking change in SQLInlineEditor.tsx:415 → onClick now captured in closure without dependencies. If ref changes, the callback still references old ref. Add ref to dependency array or remove useCallback (inline is fine for onClick)

Minor

• SetStateAction import not needed if using stable callback pattern
• Consider consolidating the new callbacks in DBSearchPage - many could be avoided with proper stable references

Recommendation

Fix the SQLInlineEditor onClick closure bug before merge. Consider removing memo from simple components - they add overhead without benefit.

[github-actions]

E2E Test Results

✅ All tests passed • 47 passed • 3 skipped • 692s

Status	Count
✅ Passed	47
❌ Failed	0
⚠️ Flaky	0
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

[pulpdrew]

LGTM