-
Notifications
You must be signed in to change notification settings - Fork 344
feat: Add materialized view support (Beta) #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 13a740e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
E2E Test Results✅ All tests passed • 46 passed • 3 skipped • 722s
Tests ran across 4 shards in parallel. |
Code ReviewCritical Issues
Important Issues
Notes
Priority: Fix the SQL injection issue before merge. |
bc58ac5 to
6ddb0eb
Compare
6ddb0eb to
bb52b86
Compare
bb52b86 to
d411308
Compare
Closes HDX-3082
Summary
This PR back-ports support for materialized views from the EE repo. Note that this feature is in Beta, and is subject to significant changes.
This feature is intended to support:
Note to Reviewer(s)
This is a large PR, but the code has largely already been reviewed.
useOffsetPaginatedQuery,useChartConfig, andDBEditTimeChartdiffer slightly due to unrelated (to MVs) drift between this repo and the EE repo, and due to the lack of feature toggles in this repo. This is where slightly closer review would be most valuable.Demo
Demo: MV Configuration
Config.MVs.mov
Demo: Chart Explorer
Chart.Explorer.mov
Demo: Dashboards
Dashboards.mov
Known Limitations
This feature is in Beta due to the following known limitations, which will be addressed in subsequent PRs:
Differences in OSS vs EE Support
Testing
To test, a couple of MVs can be created on the default
otel_tracestable, directly in ClickHouse:Example MVs DDL
Then you'll need to configure the materialized views in your source settings:
Source Configuration (should auto-infer when MVs are selected)