Skip to content

feat: Add Knip for unused code analysis with CI reporting#1954

Merged
kodiakhq[bot] merged 4 commits intomainfrom
brandon/knip
Mar 23, 2026
Merged

feat: Add Knip for unused code analysis with CI reporting#1954
kodiakhq[bot] merged 4 commits intomainfrom
brandon/knip

Conversation

@brandon-pereira
Copy link
Copy Markdown
Member

@brandon-pereira brandon-pereira commented Mar 20, 2026

Summary

Adds Knip to the monorepo to detect unused files, dependencies, and exports. The goal is to reduce dead code over time and prevent new unused code from accumulating.

What's included:

  • Root-level knip.json configured for all three workspaces (packages/app, packages/api, packages/common-utils)
  • yarn knip and yarn knip:ci scripts for local and CI usage
  • GitHub Action (.github/workflows/knip.yml) that runs on every PR to main, compares results against the base branch, and posts a summary comment showing any increase or decrease in unused code
  • Removed the previous app-only packages/app/knip.json in favor of the monorepo-wide config

How the CI workflow works:

  1. Runs Knip on the PR branch
  2. Checks out main and runs Knip there
  3. Compares issue counts per category and posts/updates a PR comment with a diff table

This is additive — Knip runs as an informational check and does not block PRs.

@brandon-pereira
feat: Add Knip for unused code analysis with CI reporting
25b13df 
Add Knip to detect unused files, dependencies, and exports across
the monorepo. Includes a GitHub Action that compares results against
main and posts a summary comment on PRs to prevent regressions.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 20, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 78a62e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 23, 2026 2:40pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2026 •
edited
Loading

Knip - Unused Code Analysis

🔴 +240 change in total issues (0 on main → 240 on PR)

Category main PR Diff
Unused files 0 9 +9 🔴
Unused dependencies 0 14 +14 🔴
Unused devDependencies 0 20 +20 🔴
Unlisted dependencies 0 14 +14 🔴
Unresolved imports 0 2 +2 🔴
Unlisted binaries 0 2 +2 🔴
Unused exports 0 132 +132 🔴
Unused exported types 0 41 +41 🔴
Unused enum members 0 2 +2 🔴
Duplicate exports 0 4 +4 🔴
What is this?

Knip finds unused files, dependencies, and exports in your codebase.
This comment compares the PR branch against main to detect regressions.

Run yarn knip locally to see full details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2026 •
edited
Loading

PR Review

  • ⚠️ knip:ci script is unused — The workflow calls yarn knip --reporter json directly instead of yarn knip:ci. Either use yarn knip:ci in the workflow or remove the knip:ci script from package.json.

  • ⚠️ Silent knip failures give false confidence — 2>/dev/null || true suppresses stderr and forces exit 0. If knip crashes, countIssues returns { total: 0 } and the comment shows "0 issues on PR" rather than indicating a tool failure. Consider at least logging stderr: yarn knip --reporter json > /tmp/knip-pr.json 2>/tmp/knip-pr-err.json || true.

  • ⚠️ Potential files category undercounting — In Knip v6 JSON output, unused files are reported at the top level (data.files: string[]), not inside data.issues[n].files. The countIssues function only iterates data.issues, so the files category count may always be 0. Verify against the actual JSON structure and add counts['files'] = (data.files || []).length if needed.

✅ Security looks fine — action versions are pinned with commit SHAs, permissions are minimal (contents: read, pull-requests: write), and no user-controlled content is unsafely interpolated into the comment body.

@brandon-pereira
fix: Harden knip CI workflow
79f4a02 
- Redirect stderr to /dev/null instead of into the JSON file to prevent
  corrupted output from silently zeroing out issue counts
- Remove namespaceMembers from counted categories since it has no
  corresponding row in the display table
- Pin action versions to commit SHAs to prevent supply-chain attacks
  via compromised tags
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2026 •
edited
Loading

E2E Test Results

✅ All tests passed • 92 passed • 3 skipped • 974s

Status Count
✅ Passed 92
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq kodiakhq Bot merged commit b642ce4 into main Mar 23, 2026
14 of 15 checks passed
@kodiakhq kodiakhq Bot deleted the brandon/knip branch March 23, 2026 14:41
knudtty pushed a commit that referenced this pull request Apr 16, 2026
@brandon-pereira
feat: Add Knip for unused code analysis with CI reporting (#1954)
f6c479f 
## Summary

Adds [Knip](https://knip.dev) to the monorepo to detect unused files, dependencies, and exports. The goal is to reduce dead code over time and prevent new unused code from accumulating.

**What's included:**
- Root-level `knip.json` configured for all three workspaces (`packages/app`, `packages/api`, `packages/common-utils`)
- `yarn knip` and `yarn knip:ci` scripts for local and CI usage
- GitHub Action (`.github/workflows/knip.yml`) that runs on every PR to `main`, compares results against the base branch, and posts a summary comment showing any increase or decrease in unused code
- Removed the previous app-only `packages/app/knip.json` in favor of the monorepo-wide config

**How the CI workflow works:**
1. Runs Knip on the PR branch
2. Checks out `main` and runs Knip there
3. Compares issue counts per category and posts/updates a PR comment with a diff table

This is additive — Knip runs as an informational check and does not block PRs.
Copilot AI pushed a commit that referenced this pull request Apr 20, 2026
@brandon-pereira @peter-leonov-ch
feat: Add Knip for unused code analysis with CI reporting (#1954)
8208a24 
## Summary

Adds [Knip](https://knip.dev) to the monorepo to detect unused files, dependencies, and exports. The goal is to reduce dead code over time and prevent new unused code from accumulating.

**What's included:**
- Root-level `knip.json` configured for all three workspaces (`packages/app`, `packages/api`, `packages/common-utils`)
- `yarn knip` and `yarn knip:ci` scripts for local and CI usage
- GitHub Action (`.github/workflows/knip.yml`) that runs on every PR to `main`, compares results against the base branch, and posts a summary comment showing any increase or decrease in unused code
- Removed the previous app-only `packages/app/knip.json` in favor of the monorepo-wide config

**How the CI workflow works:**
1. Runs Knip on the PR branch
2. Checks out `main` and runs Knip there
3. Compares issue counts per category and posts/updates a PR comment with a diff table

This is additive — Knip runs as an informational check and does not block PRs.
Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wrn14897 wrn14897 wrn14897 approved these changes

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brandon-pereira @wrn14897