feat: Add input filter pills below search input to make filters usage more clear on seach page#2039
Conversation
… more clear on seach page
🦋 Changeset detectedLatest commit: 492be87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review
✅ No critical bugs or security issues. Tests are comprehensive and cover all key behaviors. |
E2E Test Results✅ All tests passed • 127 passed • 3 skipped • 1016s
Tests ran across 4 shards in parallel. |
pulpdrew
left a comment
There was a problem hiding this comment.
Neat feature! A couple small suggestions:
| style={{ | ||
| ...pillStyle, | ||
| backgroundColor: isExcluded | ||
| ? 'var(--mantine-color-red-light)' | ||
| : 'var(--mantine-color-default-border)', | ||
| }} |
| <Text | ||
| span | ||
| size="xxs" | ||
| c="dimmed" | ||
| fw={500} | ||
| style={{ flexShrink: 0, maxWidth: 100 }} | ||
| truncate | ||
| > | ||
| {displayField} | ||
| </Text> |
There was a problem hiding this comment.
I don't think the displayField truncation is working as expected - here it adding the elipsis at the end but from the code it looks like you want it to be at the beginning (which I think makes sense).
You could truncate="start" instead to have mantine handle it. Also, with truncate here, do we need to do the .slice on the field and value?
| <Text | |
| span | |
| size="xxs" | |
| c="dimmed" | |
| fw={500} | |
| style={{ flexShrink: 0, maxWidth: 100 }} | |
| truncate | |
| > | |
| {displayField} | |
| </Text> | |
| <Text | |
| span | |
| size="xxs" | |
| c="dimmed" | |
| fw={500} | |
| style={{ flexShrink: 0, maxWidth: 100 }} | |
| truncate="start" | |
| > | |
| {displayField} | |
| </Text> |

Fixes HDX-2405