Skip to content

feat: Add input filter pills below search input to make filters usage more clear on seach page#2039

Merged
kodiakhq[bot] merged 5 commits intomainfrom
mikeshi/search-input-filter-pills
Apr 2, 2026
Merged

feat: Add input filter pills below search input to make filters usage more clear on seach page#2039
kodiakhq[bot] merged 5 commits intomainfrom
mikeshi/search-input-filter-pills

Conversation

@MikeShi42
Copy link
Copy Markdown
Contributor

image

Fixes HDX-2405

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

🦋 Changeset detected

Latest commit: 492be87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Minor
@hyperdx/api Minor
@hyperdx/otel-collector Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Apr 2, 2026 10:14pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

PR Review

  • ⚠️ ActionIcon variant="transparent" violates project conventions → Change to variant="subtle" (for the default gray close button) per agent_docs/code_style.md, which explicitly lists transparent as forbidden and calls subtle the "default ActionIcon variant". For the red excluded pill remove icon, consider variant="danger" or keep variant="subtle" with the red color.

  • ⚠️ expanded state persists across filter changes — if you're in expanded state and filters are removed (count drops to ≤8), the expanded flag stays true, so re-adding filters will bypass the collapse entirely until page reload. Consider resetting expanded via a useEffect when pills.length <= MAX_VISIBLE_PILLS.

✅ No critical bugs or security issues. Tests are comprehensive and cover all key behaviors.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

E2E Test Results

All tests passed • 127 passed • 3 skipped • 1016s

Status Count
✅ Passed 127
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Copy link
Copy Markdown
Contributor

@pulpdrew pulpdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat feature! A couple small suggestions:

Comment on lines +82 to +87
style={{
...pillStyle,
backgroundColor: isExcluded
? 'var(--mantine-color-red-light)'
: 'var(--mantine-color-default-border)',
}}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the contrast could be better in light mode

Image

Comment on lines +89 to +98
<Text
span
size="xxs"
c="dimmed"
fw={500}
style={{ flexShrink: 0, maxWidth: 100 }}
truncate
>
{displayField}
</Text>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the displayField truncation is working as expected - here it adding the elipsis at the end but from the code it looks like you want it to be at the beginning (which I think makes sense).

Image

You could truncate="start" instead to have mantine handle it. Also, with truncate here, do we need to do the .slice on the field and value?

Suggested change
<Text
span
size="xxs"
c="dimmed"
fw={500}
style={{ flexShrink: 0, maxWidth: 100 }}
truncate
>
{displayField}
</Text>
<Text
span
size="xxs"
c="dimmed"
fw={500}
style={{ flexShrink: 0, maxWidth: 100 }}
truncate="start"
>
{displayField}
</Text>

@kodiakhq kodiakhq bot merged commit 20e4720 into main Apr 2, 2026
16 checks passed
@kodiakhq kodiakhq bot deleted the mikeshi/search-input-filter-pills branch April 2, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants