Skip to content

fix: Fix duplicate key error on trace viewer ticks #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pulpdrew wants to merge 1 commit into from
Closed

fix: Fix duplicate key error on trace viewer ticks #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-planets-mate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

fix: Fix duplicate key error on trace viewer ticks
6 changes: 3 additions & 3 deletions packages/app/src/components/TimelineChart/TimelineMinimap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const TimelineMinimap = memo(function ({
const val = i * interval;
const frac = val / maxVal;
if (frac > 1) break;
result.push({ frac, label: renderMs(val) });
result.push({ val, frac, label: renderMs(val) });
}
return result;
}, [maxVal]);
Expand Down Expand Up @@ -275,9 +275,9 @@ export const TimelineMinimap = memo(function ({
onPointerUp={handlePointerUp}
onPointerCancel={handlePointerUp}
>
{ticks.map(({ frac, label }) => (
{ticks.map(({ val, frac, label }) => (
<div
key={label}
key={val}
className={styles.tick}
style={{ left: `${frac * 100}%`, height: MINIMAP_HEIGHT }}
>
Expand Down
Loading