Skip to content

fix: Prevent long attribute values from painting over the key column - #2813

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
karl/fix-attribute-layout-overlap
Aug 5, 2026
Merged

fix: Prevent long attribute values from painting over the key column#2813
kodiakhq[bot] merged 2 commits into
mainfrom
karl/fix-attribute-layout-overlap

Conversation

@karl-power

Copy link
Copy Markdown
Contributor

Summary

Prevents long attributes overlapping keys. Also removes a duplicate Span Events section.

Screenshots or video

Before After
Screenshot 2026-08-05 at 10 18 52 Screenshot 2026-08-05 at 10 19 13

How to test on Vercel preview

Preview routes: /search

References

@changeset-bot

changeset-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: be9f95f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview Aug 5, 2026 12:56pm
hyperdx-storybook Ready Ready Preview Aug 5, 2026 12:56pm

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 2
  • Production lines changed: 25
  • Branch: karl/fix-attribute-layout-overlap
  • Author: karl-power

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adjusts the JSON attribute viewer’s key-column sizing and removes a duplicate Span Events accordion section.

  • Applies the tabulated minimum width to the key container while preserving the half-row cap.
  • Retains one data-driven Span Events section and aligns its start padding with the surrounding panel mode.
  • Adds a patch changeset for @hyperdx/app.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/app/src/components/HyperJson.module.scss Moves the tabulated width floor to the actual flex sizing container and bounds it within the existing 50% maximum.
packages/app/src/components/DBRowOverviewPanel.tsx Removes a duplicate Span Events accordion item while retaining the data-driven section and adjusting its contextual padding.
.changeset/span-attributes-key-column-overlap.md Records the attribute-viewer layout fix as an application patch.

Reviews (2): Last reviewed commit: "Merge branch 'main' into karl/fix-attrib..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 270 passed • 1 skipped • 981s

Status Count
✅ Passed 270
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq
kodiakhq Bot merged commit 16bdb40 into main Aug 5, 2026
26 of 27 checks passed
@kodiakhq
kodiakhq Bot deleted the karl/fix-attribute-layout-overlap branch August 5, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants