refactor(headers): export all headers and utils directly under header

[pyfisch]

Currently headers are exported at many places. For example you can access
Transfer-Encoding header at header, header::common and
header::common::transfer_encoding. Per discussion on IRC with
@seanmonstar and @reem, all contents of headers will be exposed at header
directly.

This breaks much code using headers. It should use everything it needs
directly from header::, encodings are exposed at header::Encoding::,
connection options are exposed at header::ConnectionOption.

[reem]

The only thing I would change about this design is that the parsing helpers (from_comma_delimited, etc.) should be in their own module, since they feel like clutter here. Perhaps header::parsing?

[pyfisch]

I will change it like you propose.

By the way. Should header:: export the macros? I think they are useful for custom headers.

[reem]

Hmm. Right now macros are exported at the crate level. I think it's fine to export them, since you only get them if you #[macro_use] anyway.

[reem]

Added a bunch of nits.

[pyfisch]

Fixed all nits. Moved parsing to its own file. (Rustoc did not like it otherwise, and we also use separate files for everything else)

[reem]

Waiting on deps to run this on travis.

[pyfisch]

Can someone please rerun this on Travis, or do I need to change something in the code?

[seanmonstar]

I can't restart it on my phone, the Travis site sucks on mobile. The button
doesn't even render.

I can give it a kick when I get home.

On Mon, Jan 19, 2015, 1:12 PM Pyfisch notifications@github.com wrote:

Can someone please rerun this on Travis, or do I need to change something
in the code?

—
Reply to this email directly or view it on GitHub
#251 (comment).

[seanmonstar]

Apparently, it doesn't work on desktop either. Try opening a new PR.

[reem]

Ya, the travis site is bugging out for me too.