refactor(headers): export all headers and utils directly under header #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently headers are exported at many places. For example you can access `Transfer-Encoding` header at `header`, `header::common` and `header::common::transfer_encoding`. Per discussion on IRC with @seanmonstar and @reem, all contents of headers will be exposed at `header` directly. Parsing utilities will be exposed at `header::parsing`. Header macros can now be used from other crates. This breaks much code using headers. It should use everything it needs directly from `header::`, encodings are exposed at `header::Encoding::`, connection options are exposed at `header::ConnectionOption`.
Contributor
Author
|
Can you please merge it? It has no new changes except a very few updates for master compared to #251. |
reem
added a commit
that referenced
this pull request
Jan 21, 2015
refactor(headers): export all headers and utils directly under header
Contributor
|
@pyfisch Thanks for pushing this though, it's a very worthwhile change. |
Contributor
|
It looks like we accidentally dropped a few things from public exports - @pyfisch think you could do a pass to make sure we get everything and PR the fixes? |
Contributor
Author
|
I will look if there are things I have forgotten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently headers are exported at many places. For example you can access
Transfer-Encodingheader atheader,header::commonandheader::common::transfer_encoding. Per discussion on IRC with@seanmonstar and @reem, all contents of headers will be exposed at
headerdirectly. Parsing utilities will be exposed at
header::parsing. Headermacros can now be used from other crates.
This breaks much code using headers. It should use everything it needs
directly from
header::, encodings are exposed atheader::Encoding::,connection options are exposed at
header::ConnectionOption.