Add SslClient and SslServer implementations for security-framework#762
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Apr 17, 2016
Merged
Add SslClient and SslServer implementations for security-framework#762seanmonstar merged 1 commit intohyperium:masterfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
|
Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:
Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
💃 |
sfackler
force-pushed
the
security-framework
branch
2 times, most recently
from
b4c4728 to
ec4cc4a
Compare
sfackler
force-pushed
the
security-framework
branch
from
ec4cc4a to
f37315b
Compare
| pub type DefaultConnector = HttpsConnector<self::openssl::Openssl>; | ||
|
|
||
| #[cfg(all(feature = "security-framework", not(feature = "openssl")))] | ||
| pub type DefaultConnector = HttpsConnector<self::security_framework::ClientWrapper>; |
Member
There was a problem hiding this comment.
Openssl feature would still be enabled to provide the secure feature of cookies. So if you enable both, you'd be using the Openssl connector, right?
Contributor
Author
There was a problem hiding this comment.
If you're using that feature, yeah, though that's a thing that we can fix on the cookie side. But it seems a bit unlikely that you'd be enabling that feature anyway if you're using the client side of hyper.
Member
|
\o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.