Skip to content

Conversation

@amagyar-iohk
Copy link
Contributor

@amagyar-iohk amagyar-iohk commented Apr 18, 2025

Description:

  • Removes sinon and chai in favor of vitest
  • Updates some dev dependencies

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
@amagyar-iohk amagyar-iohk requested a review from a team as a code owner April 18, 2025 14:17
@amagyar-iohk amagyar-iohk requested a review from curtis-h April 18, 2025 14:17
@amagyar-iohk amagyar-iohk changed the title test: chai sinon removal test: chai and sinon removal Apr 18, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14536530200

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • 1047 unchanged lines in 114 files lost coverage.
  • Overall coverage increased (+7.3%) to 82.802%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pollux/utils/jwt/DER.ts 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/apollo/utils/Ed25519PrivateKey.ts 1 94.74%
src/castor/did/prismDID/LongFormPrismDID.ts 1 82.35%
src/castor/parser/DIDUrlParser.ts 1 90.91%
src/domain/models/Credential.ts 1 85.71%
src/edge-agent/Agent.Backup.ts 1 93.85%
src/edge-agent/connections/didcomm/ProblemReport.ts 1 50.0%
src/edge-agent/didcomm/CreatePeerDID.ts 1 93.65%
src/edge-agent/didcomm/HandleOOBInvitation.ts 1 92.68%
src/edge-agent/didcomm/ParseOOBInvitation.ts 1 93.33%
src/edge-agent/oidc/protocols/TokenResponse.ts 1 75.0%
Totals Coverage Status
Change from base Build 14491941277: 7.3%
Covered Lines: 9401
Relevant Lines: 11360

💛 - Coveralls

@curtis-h
Copy link
Contributor

closing in favour of #421

@curtis-h curtis-h closed this Apr 22, 2025
@amagyar-iohk amagyar-iohk deleted the tests/chai-sinon-removal branch June 23, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants