Skip to content

test: remove chai and sinon #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

test: remove chai and sinon #421

merged 1 commit into from
Apr 24, 2025

Conversation

@curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Apr 22, 2025

Description:

removing the final vestiges of chai and sinon

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Apr 22, 2025
@curtis-h curtis-h requested a review from a team as a code owner April 22, 2025 15:26
@curtis-h curtis-h requested a review from amagyar-iohk April 22, 2025 15:26
@curtis-h curtis-h mentioned this pull request Apr 22, 2025
Closed
6 tasks
@coveralls
Copy link

coveralls commented Apr 22, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14635045045

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.383%
Totals Coverage Status
Change from base Build 14615947218: 0.0%
Covered Lines: 3418
Relevant Lines: 4277
💛 - Coveralls

@curtis-h
test: remove chai and sinon
523a625 
Signed-off-by: Curtish <ch@curtish.me>
@curtis-h curtis-h merged commit a79f3ec into main Apr 24, 2025
8 checks passed
@curtis-h curtis-h deleted the test/chai-sinon branch April 24, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk

Assignees

@curtis-h curtis-h

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@curtis-h @coveralls @yshyn-iohk