Skip to content

Conversation

@curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Apr 23, 2025

Description:

Using the ES256KSigner exported by did-jwt library instead of the custom untested DER code

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Curtish <ch@curtish.me>
@curtis-h curtis-h self-assigned this Apr 23, 2025
@curtis-h curtis-h requested a review from a team as a code owner April 23, 2025 09:29
@curtis-h curtis-h requested a review from amagyar-iohk April 23, 2025 09:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14614757852

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 76.383%

Totals Coverage Status
Change from base Build 14595063837: 0.2%
Covered Lines: 3418
Relevant Lines: 4277

💛 - Coveralls

@curtis-h curtis-h merged commit 3e60ac9 into main Apr 23, 2025
7 checks passed
@curtis-h curtis-h deleted the feat/secp-signer branch April 23, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants