Skip to content

feat: CreateJWT use ES256KSigner #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

feat: CreateJWT use ES256KSigner #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/pollux/utils/jwt/CreateJwt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { Signer, createJWT } from "did-jwt";
import { ES256KSigner, Signer, createJWT } from "did-jwt";
import { base58btc } from "multiformats/bases/base58";
import * as Domain from "../../../domain";
import { asJsonObj, expect, notNil } from "../../../utils";
import { Task } from "../../../utils/tasks";
import { AgentContext } from "../../../edge-agent/didcomm/Context";
import { base64url } from "multiformats/bases/base64";
import { normaliseDER } from "./DER";

/**
* Asyncronously sign with a DID
Expand Down Expand Up @@ -33,15 +32,14 @@ export class CreateJWT extends Task<string, Args> {
}

const kid = await this.getSigningKid(ctx, this.args.did, privateKey);
const signer: Signer = async (data: any) => {
const rawSignature = privateKey.sign(Buffer.from(data));
//secp256k1 uses compact encoding while apollo returns der signatures so far
const signature = privateKey.curve === Domain.Curve.SECP256K1 ?
normaliseDER(rawSignature) :
rawSignature;
const encoded = base64url.baseEncode(signature);
return encoded;
};
// secp256k1 uses compact encoding while apollo returns der signatures so far
const signer: Signer = privateKey.curve === Domain.Curve.SECP256K1
? ES256KSigner(privateKey.raw)
: async (data: any) => {
const signature = privateKey.sign(Buffer.from(data));
const encoded = base64url.baseEncode(signature);
return encoded;
};

const jwt = await createJWT(
this.args.payload,
Expand Down
69 changes: 0 additions & 69 deletions src/pollux/utils/jwt/DER.ts
View file
Open in desktop

This file was deleted.

Loading