pools-by-connector Add connector field to TokenPoolQueryFactory #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
dechdev
requested review from
awrichar,
nguyer,
nickgaski and
peterbroadhurst
as code owners
awrichar
approved these changes
Oct 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 223 223
Lines 12374 12374
=========================================
Hits 12374 12374 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the new Tokens Page in the UI, filtering that supports getting pools by connector is needed
GET /namespaces/<namespace>/tokens/pools?connector={connectorName}returns all token pools with specified connector