Skip to content

Conversation

@dechdev
Copy link
Contributor

@dechdev dechdev commented Feb 3, 2022

to track broadcasts, private messages, and token mint/burn/transfers

Signed-off-by: David Echelberger david.echelberger@kaleido.io

…gs, and token mint/burn/transfers

Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
@awrichar
Copy link
Contributor

awrichar commented Feb 3, 2022

Will the "start time" values be accurate if there are lots of things in flight (both from me and from others)? Seems like there's not enough correlation to determine the actual time taken by one particular message, transfer, etc.

David Echelberger added 2 commits February 4, 2022 12:08
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #477 (366f29e) into main (82f55af) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #477   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          267       267           
  Lines        15257     15320   +63     
=========================================
+ Hits         15257     15320   +63     
Impacted Files Coverage Δ
internal/events/operation_update.go 100.00% <ø> (ø)
internal/assets/manager.go 100.00% <100.00%> (ø)
internal/assets/token_transfer.go 100.00% <100.00%> (ø)
internal/batch/batch_manager.go 100.00% <100.00%> (ø)
internal/broadcast/manager.go 100.00% <100.00%> (ø)
internal/broadcast/message.go 100.00% <100.00%> (ø)
internal/events/aggregator.go 100.00% <100.00%> (ø)
internal/events/aggregator_batch_state.go 100.00% <100.00%> (ø)
internal/events/event_manager.go 100.00% <100.00%> (ø)
internal/events/tokens_transferred.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f55af...366f29e. Read the comment docs.

@dechdev dechdev marked this pull request as draft February 4, 2022 19:51
@dechdev dechdev requested a review from onelapahead February 4, 2022 22:02
David Echelberger and others added 19 commits February 6, 2022 16:30
…-metrics

Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
…etrics

Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@dechdev
Copy link
Contributor Author

dechdev commented Feb 9, 2022

Closing in favor of #503

@dechdev dechdev closed this Feb 9, 2022
@dechdev dechdev deleted the new-prom-metrics branch February 11, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants