Fix bugs when running with an old config file #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
nguyer,
peterbroadhurst and
shorsher
as code owners
Technically "publicstorage" was not deprecated until 1.0.4. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
The networkVersion() method will not exist, but we should cache the fact that is doesn't exist as proof of a V1 contract. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
shorsher
approved these changes
Aug 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 301 301
Lines 19800 19815 +15
=======================================
+ Hits 19799 19814 +15
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
No automatic migration path is provided - admin server will not be started, but the message provides a clearer path to correcting the config. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FireFly should continue to work when run against a config file from 1.0.x.
Since this references 1.0.4, it should go in after #982 is merged and released as 1.0.4.