Skip to content

fix(deps): align Hyperlight 0.17 and hyperlight-js 0.4.0 - #349

Merged
simongdavies merged 2 commits into
mainfrom
simongdavies-combined-hyperlight-updates
Sep 7, 2026
Merged

fix(deps): align Hyperlight 0.17 and hyperlight-js 0.4.0#349
simongdavies merged 2 commits into
mainfrom
simongdavies-combined-hyperlight-updates

Conversation

@simongdavies

@simongdavies simongdavies commented Sep 7, 2026

Copy link
Copy Markdown
Member

Summary

CI investigation and validation

#338 and #339 fail with guest-function trait mismatches from mixed Hyperlight versions. #337 fails at both guest buffer constructors with expected Vec<u8>, found &[u8].

All CI checks pass on final commit 44436ba, including the hyperlight-js 0.4.0 update: Validate Pull Request run. This covers Linux KVM and MSHV debug/release, Windows WHP debug/release, lint and tests, Windows Clippy, PDF visual regression, and Docker build. CodeQL and DCO also pass.

Local Rust formatting and version/lock metadata consistency checks pass. Local just build and just check are blocked by a Windows linker output-path failure building Hyperlight's surrogate. Automatic npm lockfile regeneration also encounters an unavailable pre-existing @napi-rs/cli@^3.9.0 dependency on the local registry mirror; only the local addon version metadata was adjusted, and its metadata was compared with the pinned release manifest.

Future Hyperlight Dependabot version-update grouping is proposed separately in #350.

Closes #337
Closes #338
Closes #339
Closes #345

Combine the dependency updates from #337, #338 and #339 to keep the host and guest crates compatible. Adapt both embedded guest binary constructors to the owned buffer API in hyperlight-host 0.17.0.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 7, 2026 17:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated dependency pinning makes an existing Cargo.toml comment misleading relative to the still-0.16 hyperlight-js runtime workspace, and it should be corrected to avoid confusion.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the code-validator analysis guest workspace to use a consistent set of Hyperlight 0.17.0 crates, regenerates the workspace lockfile to remove mixed 0.16/0.17 dependencies, and adapts the analysis-host sandbox construction to the hyperlight-host 0.17.0 breaking change where GuestBinary::Buffer must own a Vec<u8>.

Changes:

  • Bumped hyperlight-{guest,guest-bin,host} in the analysis guest workspace to 0.17.0 and regenerated Cargo.lock to eliminate mixed-version resolution.
  • Updated both embedded guest binary construction sites to GuestBinary::Buffer(ANALYSIS_RUNTIME.to_vec()) to match the new Vec<u8> ownership requirement.
  • Left the separate sandbox/hyperlight-js runtime workspace unchanged.
File summaries
File Description
src/code-validator/guest/host/src/sandbox.rs Updates embedded guest binary construction to pass an owned Vec<u8> into GuestBinary::Buffer.
src/code-validator/guest/Cargo.toml Aligns analysis-workspace Hyperlight crate versions to 0.17.0.
src/code-validator/guest/Cargo.lock Regenerates lockfile to remove mixed 0.16/0.17 Hyperlight dependencies and reflect new transitive deps.
Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/code-validator/guest/Cargo.toml
Update the source-built host addon tag and sandbox runtime together, refresh their lockfile metadata, and correct the analysis workspace's version-alignment comment.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@simongdavies simongdavies changed the title fix(deps): update Hyperlight analysis crates together to 0.17.0 fix(deps): align Hyperlight 0.17 and hyperlight-js 0.4.0 Sep 7, 2026
@simongdavies
simongdavies enabled auto-merge (squash) September 7, 2026 17:53
@simongdavies
simongdavies merged commit 51e719d into main Sep 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants