fix: resolve symlinks in launcher script for npm global install#6
Merged
simongdavies merged 1 commit intohyperlight-dev:mainfrom Mar 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the binary build process to generate a Unix shell launcher that can locate the packaged lib/ directory correctly even when the executable is installed as an npm global symlink (common for npm i -g).
Changes:
- Update the generated Unix launcher to resolve symlinks (via
readlink -f/realpath) before computing the path tolib/hyperagent-launcher.cjs.
The shell launcher used ${0%/*} to find its lib/ directory, but when
npm installs globally it creates a symlink in the bin dir. ${0%/*}
resolves to the npm bin dir, not the package dir, causing:
Cannot find module '.../lib/hyperagent-launcher.cjs'
Use readlink -f / realpath to resolve symlinks before computing the
relative path to the lib directory.
Tested: symlink from /tmp/ → prints version correctly; old approach
confirmed to fail with MODULE_NOT_FOUND.
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-npm-launcher
branch
from
c24da67 to
30ff929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell launcher used ${0%/} to find its lib/ directory, but when npm installs globally it creates a symlink in the bin dir. ${0%/} resolves to the npm bin dir, not the package dir, causing:
Cannot find module '.../lib/hyperagent-launcher.cjs'
Use readlink -f / realpath to resolve symlinks before computing the relative path to the lib directory.
Tested: symlink from /tmp/ → prints version correctly; old approach confirmed to fail with MODULE_NOT_FOUND.