Fix musl error assertion#1653
Merged
Merged
Conversation
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
July 17, 2026 21:24
ludfjig
force-pushed
the
fix_musl_symbol_error
branch
from
July 17, 2026 21:25
eddcc9c to
c111daa
Compare
ludfjig
added
kind/bugfix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky Linux musl nightly failure by making the snapshot symlink-rejection tests robust to libc-specific error wording differences.
Changes:
- Update two unit tests to avoid depending on exact libc capitalization/pluralization in the symlink error message.
ludfjig
force-pushed
the
fix_musl_symbol_error
branch
from
July 17, 2026 21:35
c111daa to
9856278
Compare
jsturtevant
approved these changes
Jul 17, 2026
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
fix_musl_symbol_error
branch
from
July 17, 2026 23:53
9856278 to
7e820f3
Compare
ludfjig
enabled auto-merge (squash)
July 17, 2026 23:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1620