fix(sonar): point at this repo's own SonarCloud project - #25
Merged
Conversation
sonar.projectKey was hyperpolymath_rsr-template-repo, copied verbatim from the RSR template this repo was derived from. The workflow currently fails at authentication (no SONAR_TOKEN secret), so nothing is being mis-submitted today -- but once a token is added this repo would report into the template's project alongside every other repo with the copied key. Fix the key first. Organisation is unchanged: the estate consolidates SonarCloud under the single hyperpolymath org (metadatastician/IDApTIK#42). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
hyperpolymath
marked this pull request as ready for review
July 27, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
sonar.projectKeywashyperpolymath_rsr-template-repo— the template repo's own key, copied verbatim when this repo was derived from it. Points it at its own project instead.sonar.organizationis unchanged.Why now, and why keys before tokens
This repo has no
SONAR_TOKENsecret, so the scan currently aborts at authentication and submits nothing:So the wrong key is latent, not actively corrupting anything. But the moment
SONAR_TOKENis added, this repo would start reporting its analysis intohyperpolymath_rsr-template-repo, mixed in with every other repo carrying the copied key. Fixing the key first means that never happens.Found in an estate-wide sweep of
sonar-project.propertiesfiles against the SonarCloud API. Same fix already merged in hyperpolymath/systemet#20 and hyperpolymath/rsr-julia-library-template-repo#16.Organisation
hyperpolymathis correct and unchanged here. The estate consolidates SonarCloud under the singlehyperpolymathorganisation regardless of GitHub org — settled in metadatastician/IDApTIK#42.Test plan
sonar.projectKeyand the project URL in the header comment changesonar.organizationuntouchedSONAR_TOKEN— the workflow cannot pass without both, independent of this change🤖 Generated with Claude Code