Skip to content

chore(ci): repoint push-email-notify to smtp-notify-action - #44

Open
hyperpolymath wants to merge 1 commit into
mainfrom
chore/smtp-notify-action
Open

chore(ci): repoint push-email-notify to smtp-notify-action#44
hyperpolymath wants to merge 1 commit into
mainfrom
chore/smtp-notify-action

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Replaces dawidd6/action-send-mail with hyperpolymath/smtp-notify-action v0.1.0 (tag commit 1b3b752d39a4fe4c0f28f10905e4608789d3e050), per the 2026-09-02 ruling (standards spec §5.5/§9, PR hyperpolymath/standards#725). The whole file is the rsr-template-repo canonical, so besides the uses: line it also: limits the trigger to branch pushes (tag/deletion payloads mislabel Branch:), drops actions: read (unused), and adds timeout-minutes: 5. Dormant gating on vars.PUSH_EMAIL_ENABLED == 'true' is unchanged. Line 1 SPDX header kept as it was.

Engine: .git-private-farm/scripts/smtp-notify-sweep.sh. Verification for this repo: regime=lock pristine=valid post=valid changed=.github/workflows/actions.lock,.github/workflows/push-email-notify.yml, sig=G 79d30cd base=main
(pristine/post = gh actions-lock --no-fix validity before/after; repair = the lock was already invalid before this change and is valid after it.)

🤖 Generated with Claude Code

Replaces dawidd6/action-send-mail with hyperpolymath/smtp-notify-action v0.1.0 (1b3b752d39a4fe4c0f28f10905e4608789d3e050) per the 2026-09-02 ruling; file is the rsr-template-repo canonical (dormant gating on vars.PUSH_EMAIL_ENABLED unchanged). regime=lock pristine=valid post=valid changed=.github/workflows/actions.lock,.github/workflows/push-email-notify.yml,

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 2697ef89-7863-4975-afc7-37937a578f3a

📥 Commits

Reviewing files that changed from the base of the PR and between 9349cc6 and 79d30cd.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .github/workflows/push-email-notify.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🔇 Additional comments (1)
.github/workflows/push-email-notify.yml (1)

7-11: LGTM!

Also applies to: 17-18, 24-24


📝 Summary

Summary by CodeRabbit

  • Updates
    • Push email notifications now run only for branch pushes.
    • Notification delivery has been updated to improve consistency and reproducibility.
    • Jobs now stop automatically after five minutes if they do not complete.

Walkthrough

The push-email workflow now runs only for branch pushes, uses contents: read, stops after five minutes, and sends mail through hyperpolymath/smtp-notify-action@v0.1.0.

Changes

Push email notification workflow

Layer / File(s) Summary
Workflow controls and mail delivery
.github/workflows/push-email-notify.yml
The workflow limits triggers to branch pushes, removes actions: read, adds a five-minute timeout, and replaces the mail-sending action. Comments document the re-landing and action pin authority.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 79d30

This PR updates the push-email workflow and its action lock while preserving the existing email gating; no actionable merge-blocking risk remains after normal checks and review.

Poem

A rabbit checks the branch at dawn
The mail hops out when tags are gone
Five minutes guards the little run
Read-only paws keep access none
SMTP carries news to everyone

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: it repoints the push email notification workflow to the new SMTP notification action.
Description check ✅ Passed The description is directly related to the changeset. It covers the action replacement, commit pin, workflow trigger, permissions, timeout, gating, and verification details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant