fix(ci): restore top-level env block dropped by consolidation #258#534
Merged
Conversation
…#258 #258 ('consolidate 37 workflows -> 23, behaviour-preserving') moved the container jobs from container.yml into release.yml but did NOT carry the top-level env: block — and env: is file-scoped, so env.REGISTRY/env.IMAGE_NAME silently went undefined. That broke ghcr login, image metadata/push tags, and (latterly) the attestation subject-name. Restores: env: REGISTRY: ghcr.io IMAGE_NAME: ${{ github.repository }} (the values from 0d310fa, where the block originally lived). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of the undefined
env.REGISTRY/env.IMAGE_NAME: the v1.0 commit0d310fahad the top-levelenv:block, but the workflow-consolidation PR #258 ('consolidate 37 workflows → 23, behaviour-preserving') moved the container jobs fromcontainer.ymlintorelease.ymlwithout carrying theenv:block — andenv:is file-scoped, so it didn't travel with the moved jobs. The vars went undefined, breaking ghcr login, metadata/push tags, and the attest subject-name. So it was fixed before; the consolidation regressed it. Restores the originalREGISTRY: ghcr.io/IMAGE_NAME: ${{ github.repository }}. 🤖 Generated with Claude Code