Skip to content

ci: vendor validation scripts and remove remote action pins - #46

Merged
hyperpolymath merged 1 commit into
mainfrom
fix-ci-actions
Jul 27, 2026
Merged

ci: vendor validation scripts and remove remote action pins#46
hyperpolymath merged 1 commit into
mainfrom
fix-ci-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Automated PR to fix CI after deleted actions.

@sonarqubecloud

Copy link
Copy Markdown

Comment thread .githooks/validate-a2ml.sh
@gitar-bot

gitar-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Vendors validation scripts and removes remote action pins to fix CI workflows. Ensure while read loops handle files missing a trailing newline to prevent skipping the final line.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

✅ 1 resolved
Edge Case: while-read loops skip a file's final line without trailing newline

📄 .githooks/validate-a2ml.sh:102-111 📄 .githooks/validate-a2ml.sh:128-142 📄 .githooks/validate-a2ml.sh:239-253 📄 .githooks/validate-a2ml.sh:270-280
All while IFS= read -r line; do ... done < "$file" loops rely on read succeeding, which returns non-zero (skipping the loop body) for a final line that lacks a trailing newline. A K9/A2ML file whose last line is the only content (e.g. a single-line file, or a pedigree/identity field on the last unterminated line) would be silently skipped, producing false 'Missing K9! magic number' / 'Missing identity field' errors. Guard with while IFS= read -r line || [[ -n "$line" ]]; do.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@hyperpolymath
hyperpolymath merged commit cd496e8 into main Jul 27, 2026
19 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the fix-ci-actions branch July 27, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant