-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyperpolymath
wants to merge
3
commits into
main
Choose a base branch
from
chore/estate-topup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,4 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # CODEOWNERS - Define code review assignments for GitHub | ||
| # See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners | ||
|
|
||
| # Default: sole maintainer for all files | ||
| * @hyperpolymath | ||
|
|
||
| # Security-sensitive files require explicit ownership | ||
| SECURITY.md @hyperpolymath | ||
| .github/workflows/ @hyperpolymath | ||
| .machine_readable/ @hyperpolymath | ||
| contractiles/ @hyperpolymath | ||
|
|
||
| # License files | ||
| LICENSE @hyperpolymath | ||
| LICENSES/ @hyperpolymath | ||
|
|
||
| # Configuration | ||
| .gitignore @hyperpolymath | ||
| .github/ @hyperpolymath | ||
|
|
||
| # Documentation | ||
| README* @hyperpolymath | ||
| CONTRIBUTING* @hyperpolymath | ||
| CODE_OF_CONDUCT* @hyperpolymath | ||
| GOVERNANCE* @hyperpolymath | ||
| MAINTAINERS* @hyperpolymath | ||
| CHANGELOG* @hyperpolymath | ||
| ROADMAP* @hyperpolymath | ||
|
|
||
| # Build and CI | ||
| Justfile @hyperpolymath | ||
| Makefile @hyperpolymath | ||
| *.sh @hyperpolymath | ||
| # Solo-maintained hyperpolymath repo: no owner lines by policy. | ||
| # See hyperpolymath/standards CODEOWNERS-POLICY.adoc (Rule 1). | ||
| # Sole-maintainer review is moot; SPDX headers carry attribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| <!-- SPDX-License-Identifier: CC-BY-SA-4.0 --> | ||
|
|
||
| # REQUIRES INITIALISATION | ||
|
|
||
| **This repository is not finished being set up.** 7 substitution token(s) across 3 file(s) still have no value. | ||
|
|
||
| ## Why this is not already done | ||
|
|
||
| This repo was created from `hyperpolymath/rsr-template-repo`. The mint | ||
| (`just repo-init`) fills every token that has a single mechanical answer — | ||
| owner, repo, author, dates, licence, branch — and it has done so here. | ||
|
|
||
| The tokens below are the ones it *deliberately cannot* answer. They need a | ||
| decision or a fact that exists only in your head: what this project is for, | ||
| what command builds it, which port the service listens on, whether a PGP key | ||
| is held at all. The template's own token vocabulary says as much — you cannot | ||
| sensibly answer "required invariants" in a thirty-second bootstrap. | ||
|
|
||
| They were left **visibly unfilled on purpose**. The alternatives were both | ||
| worse: inventing plausible values would put confident falsehoods into a | ||
| security policy and an architecture document, and silently deleting the | ||
| sections would hide the fact that a decision is owed. A visible gap is | ||
| honest; a fabricated answer is not. | ||
|
|
||
| ## Do not delete this file until every item below is resolved | ||
|
|
||
| This file is the only marker that the work is outstanding. Deleting it early | ||
| does not finish the setup, it just conceals it — and the next person or agent | ||
| to arrive will reasonably assume the repo is complete. | ||
|
|
||
| - **If you are a person:** delete this file yourself once the last item is done. | ||
| - **If you are an agent:** resolve what you legitimately can, leave the rest, | ||
| and delete this file only when no token below remains anywhere in the tree. | ||
| Do not delete it to make a gate go green. | ||
|
|
||
| Re-running the estate top-up tool will remove this file automatically once | ||
| nothing is outstanding, so the safest way to finish is to fix the tokens and | ||
| let the check confirm it. | ||
|
|
||
| ## What is needed, and where it goes | ||
|
|
||
| ### `{{BUILD_CMD}}` | ||
|
|
||
| The exact command that builds this project. | ||
|
|
||
| Appears in: | ||
|
|
||
| - `QUICKSTART-DEV.adoc` | ||
|
|
||
| ### `{{BUILD_OUTPUT_PATH}}` | ||
|
|
||
| Where the build artefact lands. | ||
|
|
||
| Appears in: | ||
|
|
||
| - `QUICKSTART-MAINTAINER.adoc` | ||
|
|
||
| ### `{{DEPS}}` | ||
|
|
||
| Prose summary of runtime/build dependencies. | ||
|
|
||
| Appears in: | ||
|
|
||
| - `QUICKSTART-MAINTAINER.adoc` | ||
|
|
||
| ### `{{LANG_STACK}}` | ||
|
|
||
| The language stack, in prose. | ||
|
|
||
| Appears in: | ||
|
|
||
| - `QUICKSTART-DEV.adoc` | ||
|
|
||
| ### `{{MUST_INVARIANTS}}` | ||
|
|
||
| The invariants this project guarantees. Not answerable in a bootstrap; it is the point of the repo. | ||
|
|
||
| Appears in: | ||
|
|
||
| - `QUICKSTART-DEV.adoc` | ||
|
|
||
| ### `{{PROJECT_UNIQUE_STRENGTH}}` | ||
|
|
||
| What this does that its alternatives do not. | ||
|
|
||
| Appears in: | ||
|
|
||
| - `.machine_readable/bot_directives/methodology.a2ml` | ||
|
|
||
| ### `{{TEST_CMD}}` | ||
|
|
||
| The exact command that runs its tests. | ||
|
|
||
| Appears in: | ||
|
|
||
| - `QUICKSTART-DEV.adoc` | ||
|
|
||
| --- | ||
|
|
||
| Generated by the estate top-up pass. Rationale and the governing rulings are | ||
| in `hyperpolymath/standards`; the token vocabulary is | ||
| `.machine_readable/ai/PLACEHOLDERS.adoc` in `rsr-template-repo`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The top-up pass substituted the project name into the guards' own reject lists, turning the
{{PROJECT}}detection token into the literalJANUSKEY. This has two bad effects: (1) the guards no longer detect an unfilled{{PROJECT}}placeholder in STATE.a2ml — the very template-staleness case they exist to catch now passes silently; (2) they will now reject/warn on any legitimate STATE.a2ml that contains the stringJANUSKEY(e.g. an uppercased project name in a heading or field), producing false positives. Restore the meta-token{{PROJECT}}in bothreject-if-containsandreject_patterns— it is a guard vocabulary term, not a value to be filled.Fix 1: methodology.a2ml line 104: keep the placeholder token, not the substituted name.
Fix 2: methodology-guard.k9.ncl line 64: keep the placeholder token, not the substituted name.
Check a box to apply a fix or reply for a change | Was this helpful? React with 👍 / 👎