ci(hardening): curl|sh installers → download-then-run#37
Merged
Conversation
Clears the Hypatia download_then_run / shell_download_then_run findings by removing the pipe-to-shell pattern: download the installer to a file first, then execute it (so it can be inspected/checksummed before running). - proof-regression.yml: elan installer (Lean toolchain) download-then-run. - setup.sh: the `just` installer (2 sites) + the usage one-liner comment. Deferred (cannot do from this session): secret-scanner.yml and scorecard.yml job-permissions both require the hyperpolymath/standards reusable contract, which is out of this session's MCP scope (private; WebFetch 403) with only a partial SHA known -- guessing the ref would break the workflow. https://claude.ai/code/session_01BJmfoz1ZS1Pejy9LLMY742
🔍 Hypatia Security ScanFindings: 51 issues detected
View findings[
{
"reason": "No test directory or test files found",
"type": "no_tests",
"file": "/home/runner/work/julia-the-viper/julia-the-viper",
"action": "flag",
"rule_module": "honest_completion",
"severity": "high",
"deduction": 20
},
{
"reason": "Issue in secret-scanner.yml",
"type": "missing_workflow",
"file": "secret-scanner.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in scorecard.yml",
"type": "scorecard_wrapper_missing_job_permissions",
"file": "scorecard.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "unwrap() without prior check -- DoS via panic (10 occurrences, CWE-754)",
"type": "unwrap_without_check",
"file": "/home/runner/work/julia-the-viper/julia-the-viper/crates/jtv-core/benches/interpreter_bench.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "unwrap() without prior check -- DoS via panic (6 occurrences, CWE-754)",
"type": "unwrap_without_check",
"file": "/home/runner/work/julia-the-viper/julia-the-viper/crates/jtv-core/benches/parser_bench.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Js.Array2 deprecated -- use Array (3 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/julia-the-viper/julia-the-viper/vscode-extension/src/Extension.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Js.Promise deprecated -- use Promise (2 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/julia-the-viper/julia-the-viper/vscode-extension/src/Extension.res",
"action": "module_replace",
"rule_module": "migration_rules",
"severity": "medium"
},
{
"reason": "Belt.Array deprecated -- use Array (30 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/julia-the-viper/julia-the-viper/packages/jtv-analyzer/src/Main.res",
"action": "module_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Belt.Option deprecated -- use Option (2 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/julia-the-viper/julia-the-viper/packages/jtv-analyzer/src/Main.res",
"action": "module_replace",
"rule_module": "migration_rules",
"severity": "medium"
},
{
"reason": "Js.Array2 deprecated -- use Array (7 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/julia-the-viper/julia-the-viper/packages/jtv-analyzer/src/Main.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
hyperpolymath
marked this pull request as ready for review
June 18, 2026 00:02
hyperpolymath
pushed a commit
that referenced
this pull request
Jun 18, 2026
Records the approved resolution of the ADR-0007 D2 open tension (the surviving DataExpr.neg primitive): - neg leaves the purist core; in purist-jtv `-` is a parse error and subtraction is reverse-only (effect-level), in every number system. - neg/`-` is re-admitted only under an optional feature-gated `sugar` aspect (adulterated-jtv), with a discouragement lint -- works but nags. - the compiler stamps every build with a purity certificate (purist vs adulterated), making the escape hatch visible and accountable, not silent. - chosen architecture: feature-gated dialect (rung 1); sidecar desugarer and co-product grammar noted as future purity upgrades. Key insight recorded: subtraction-as-reverse-addition is effect-level while neg is expression-level -- that mismatch is why neg is the escape hatch. Decision record only; feature-gating + lint + certificate are follow-on implementation. STATE.a2ml: artefact location + session-history catch-up (license #36, hardening #37, ADR-0008). https://claude.ai/code/session_01BJmfoz1ZS1Pejy9LLMY742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the workflow-hardening pass. Removes the
curl | shpipe-to-shell pattern from the installer sites, clearing the Hypatiadownload_then_run/shell_download_then_runfindings.Done
proof-regression.yml— the elan (Lean toolchain) installer now downloads to a file, then executes, instead ofcurl … | sh.setup.sh— thejustinstaller (both sites) + the usage one-liner comment switched to download-then-run (download, inspect, then run — on-brand for a security language).rsr_checkfalse-positive earlier in this branch's history).Deferred — can't do safely from this session
Both need the
hyperpolymath/standardsreusable contract, which is out of this session's MCP scope (the repo is private —WebFetch403 — andlist_repos/add_repoaren't surfaced here). I only have a partial SHA (524523c) from STATE, and guessing the filename/full-SHA would break the workflow:secret-scanner.yml(missing_workflow) — needshyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@<full-SHA>.scorecard.ymljob-permissions — needs the scorecard reusable's permission contract (too-narrow perms break supply-chain scanning).To finish those I'd need the reusable refs,
standardsadded to scope, or for you to apply them.https://claude.ai/code/session_01BJmfoz1ZS1Pejy9LLMY742
Generated by Claude Code