style(clippy): idiom sweep across lib/common, mylang, and checker (3/4 of #22)

[hyperpolymath]

Summary

Mechanical idiom sweep across lib/common, lib/mylang, and checker.rs. No behaviour change in any code path; all touched modules continue to test green.

Changes

checker.rs (7 sites total):

• 6x if let Err(_) = X { .. } -> if X.is_err() { .. } (clippy::redundant_pattern_matching) -- define_effect, define_ai_model, define_prompt, and three symbols.define(Symbol { .. }) sites for functions, parameters, variables.
• 1x .iter().zip(..).enumerate() whose index was already discarded via _i -> drop the enumerate and bind the zipped pair directly.

lib/common/string.rs (3 sites):

• radix < 2 || radix > 36 -> !(2..=36).contains(&radix) (clippy::manual_range_contains).
• 2x std::iter::repeat(pad).take(N).collect() -> std::iter::repeat_n(pad, N).collect() (clippy::manual_repeat_n, stable in Rust 1.82+).

lib/common/types.rs (3 sites):

• Same radix range fix as string.rs.
• assert_eq!(int_to_bool(0), false) / ..(.., true) -> assert!(!..) / assert!(..) (clippy::bool_assert_comparison).

lib/common/utils.rs (4 sites):

• self.next_u64() % 2 == 0 -> self.next_u64().is_multiple_of(2) (clippy::manual_is_multiple_of).
• 3x r >= a && r < b / r >= a && r <= b -> (a..b).contains(&r) / (a..=b).contains(&r) (clippy::manual_range_contains).

lib/common/array.rs (1 site):

• slice(&vec![1,2,3,4,5], ..) -> slice(&[1,2,3,4,5], ..) (clippy::useless_vec).

lib/mylang/ai.rs:26 and lib/mylang/prompt.rs:139 (the method-name-shadowing sites): kept as-is with #[allow(clippy::should_implement_trait)] + a one-line rationale each. Implementing the suggested traits would be the wrong shape:

• AiModelType::from_str is infallible (every string maps to some variant; unknown names fall through to Local). Implementing FromStr would force callers to .unwrap() an Infallible everywhere.
• PromptBuilder::add is a fluent builder. std::ops::Add is for the + operator and consumes two operands; this returns Self for chaining. Wrong semantics.

Out of scope (kept clean for this PR)

• parser.rs errors.len() > 0 (6 sites in error-recovery tests) -- overlaps with the depth-guard PR feat(parser): add MAX_PARSE_EXPR_DEPTH guard + recover partial AST (closes #15) #21 still in review. Will land cleanly once feat(parser): add MAX_PARSE_EXPR_DEPTH guard + recover partial AST (closes #15) #21 merges; not worth merge-conflict risk to stuff into this PR.
• approx_constant errors -- PR1 (fix(lint): clear 5 clippy::approx_constant errors (1/4 of #22) #23).
• The two real correctness bugs (filter_map infinite loop, i64::abs() as u64) -- PR2 (fix(lib/common): two latent correctness bugs in stdin/radix paths (2/4 of #22) #24).
• Dead-code cleanup (parse_comptime_decl, derivable Display impl, unused fields in my-pkg/my-mir/my-ai) -- PR4.

RCA position

Part 3 of 4. Severity-ordered behind PR1 (lint-gate) and PR2 (real bugs). This PR is style only -- safe to merge in any order relative to PR1/PR2.

Test plan

• cargo test -p my-lang --lib library:: -- 57/57 pass.
• cargo test -p my-lang --lib checker:: -- 11/11 pass.
• cargo clippy -p my-lang --lib --tests --no-deps -- redundant_pattern_matching / manual_range_contains / manual_repeat_n / bool_assert_comparison / useless_vec / manual_is_multiple_of / should_implement_trait warnings all cleared (verified by absence from the post-change warning list).
• Branch is off clean origin/main; does not depend on PR1 (fix(lint): clear 5 clippy::approx_constant errors (1/4 of #22) #23) or PR2 (fix(lib/common): two latent correctness bugs in stdin/radix paths (2/4 of #22) #24).

[github-actions]

🔍 Hypatia Security Scan

Findings: 45 issues detected

Severity	Count
🔴 Critical	8
🟠 High	19
🟡 Medium	18

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "codeql.yml lists `language: javascript-typescript` but the repo has no source files in any CodeQL-scannable language. The analyze job will exit 'no source files' on every run. Switch the matrix to `actions` (which scans workflow files — every repo has those).",
    "type": "codeql_language_matrix_mismatch",
    "file": "codeql.yml",
    "action": "switch_codeql_matrix_to_actions",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Admitted leaves proof hole (1 occurrences, CWE-704)",
    "type": "admitted",
    "file": "/home/runner/work/my-lang/my-lang/proofs/verification/coq/Typing.v",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "critical"
  },
  {
    "reason": "Docker reference in Nickel config -- RSR requires Podman/Containerfile (1 occurrences, CWE-1104)",
    "type": "ncl_docker_not_podman",
    "file": "/home/runner/work/my-lang/my-lang/.machine_readable/svc/k9/my-lang-metadata.k9.ncl",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "unwrap() without prior check -- DoS via panic (1 occurrences, CWE-754)",
    "type": "unwrap_without_check",
    "file": "/home/runner/work/my-lang/my-lang/my-ssg/src/generator.rs",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "reason": "unwrap() without prior check -- DoS via panic (2 occurrences, CWE-754)",
    "type": "unwrap_without_check",
    "file": "/home/runner/work/my-lang/my-lang/src/proptest.rs",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "reason": "panic! macro causes unrecoverable crash (1 occurrences, CWE-754)",
    "type": "panic_macro",
    "file": "/home/runner/work/my-lang/my-lang/src/proptest.rs",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "reason": "unwrap_or(0) with dangerous default (1 occurrences, CWE-754)",
    "type": "unwrap_dangerous_default",
    "file": "/home/runner/work/my-lang/my-lang/playground/hives/me/crates/parser/src/lib.rs",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "critical"
  },
  {
    "reason": "expect() in hot path (80 occurrences, CWE-754)",
    "type": "expect_in_hot_path",
    "file": "/home/runner/work/my-lang/my-lang/playground/hives/me/crates/parser/src/lib.rs",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "unwrap() without prior check -- DoS via panic (13 occurrences, CWE-754)",
    "type": "unwrap_without_check",
    "file": "/home/runner/work/my-lang/my-lang/lib/common/concurrency.rs",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "reason": "Lock.unwrap() without poison handling (8 occurrences, CWE-754)",
    "type": "lock_unwrap",
    "file": "/home/runner/work/my-lang/my-lang/lib/common/concurrency.rs",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence