Skip to content

fix: post-merge CI feedback from #22 — deprecated APIs, workflow timeouts#24

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/project-scope-planning-5zoaze
Jul 2, 2026
Merged

fix: post-merge CI feedback from #22 — deprecated APIs, workflow timeouts#24
hyperpolymath merged 1 commit into
mainfrom
claude/project-scope-planning-5zoaze

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Small follow-up addressing the CI feedback that arrived on #22 after merge:

  • ui: replace deprecated Js.Dict.t / Js.Nullable with RescriptCore Dict.t / Nullable in WasmStore.res and Persist.res — resolves Hypatia code-scanning alerts 143 and 144. Same runtime representation; ReScript compiles clean and all deno test suites pass.
  • ci: add timeout-minutes to the rust-ci and ui-ci jobs (Hypatia workflow_audit: missing_timeout_minutes). Only the two workflows introduced in Web-first resurrection: UI builds and runs on the WASM Rust core, real CI, docs truth reset #22 are touched; the estate workflows' findings are left to estate propagation.

Deliberately not addressed here (estate-level decisions, pre-existing on main):

  • governance / Language / package anti-pattern policy — the standards HEAD now bans ReScript in favour of AffineScript; every existing .res file trips it and the AffineScript compiler isn't available outside the estate. The check's own remediation path is a .hypatia-baseline.json / .hypatia-ignore exemption — happy to add a grandfathering entry if that's the desired policy call.
  • governance / Check Workflow Staleness — flags scorecard.yml uploading SARIF without running per-PR; scorecard.yml is estate-canonical and untouched by this branch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PAEqVP7Y3bZDhtAaPUTbps


Generated by Claude Code

- ui: replace deprecated Js.Dict.t / Js.Nullable with RescriptCore
  Dict.t / Nullable (Hypatia code-scanning alerts 143, 144)
- ci: add timeout-minutes to the rust-ci and ui-ci jobs
  (Hypatia workflow_audit: missing_timeout_minutes)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PAEqVP7Y3bZDhtAaPUTbps
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 61 issues detected

Severity Count
🔴 Critical 1
🟠 High 24
🟡 Medium 36

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Issue in boj-build.yml",
    "type": "missing_timeout_minutes",
    "file": "boj-build.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "missing_timeout_minutes",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in hypatia-scan.yml",
    "type": "missing_timeout_minutes",
    "file": "hypatia-scan.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath
hyperpolymath marked this pull request as ready for review July 2, 2026 15:38
@hyperpolymath
hyperpolymath merged commit 171fdd2 into main Jul 2, 2026
22 of 24 checks passed
@hyperpolymath
hyperpolymath deleted the claude/project-scope-planning-5zoaze branch July 2, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants