fix: post-merge CI feedback from #22 — deprecated APIs, workflow timeouts#24
Merged
Merged
Conversation
- ui: replace deprecated Js.Dict.t / Js.Nullable with RescriptCore Dict.t / Nullable (Hypatia code-scanning alerts 143, 144) - ci: add timeout-minutes to the rust-ci and ui-ci jobs (Hypatia workflow_audit: missing_timeout_minutes) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PAEqVP7Y3bZDhtAaPUTbps
|
🔍 Hypatia Security ScanFindings: 61 issues detected
View findings[
{
"reason": "Issue in boj-build.yml",
"type": "missing_timeout_minutes",
"file": "boj-build.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "missing_timeout_minutes",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "missing_timeout_minutes",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in codeql.yml",
"type": "missing_timeout_minutes",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in hypatia-scan.yml",
"type": "missing_timeout_minutes",
"file": "hypatia-scan.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
hyperpolymath
marked this pull request as ready for review
July 2, 2026 15:38
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Small follow-up addressing the CI feedback that arrived on #22 after merge:
Js.Dict.t/Js.Nullablewith RescriptCoreDict.t/NullableinWasmStore.resandPersist.res— resolves Hypatia code-scanning alerts 143 and 144. Same runtime representation; ReScript compiles clean and alldeno testsuites pass.timeout-minutesto therust-ciandui-cijobs (Hypatiaworkflow_audit: missing_timeout_minutes). Only the two workflows introduced in Web-first resurrection: UI builds and runs on the WASM Rust core, real CI, docs truth reset #22 are touched; the estate workflows' findings are left to estate propagation.Deliberately not addressed here (estate-level decisions, pre-existing on
main):governance / Language / package anti-pattern policy— the standards HEAD now bans ReScript in favour of AffineScript; every existing.resfile trips it and the AffineScript compiler isn't available outside the estate. The check's own remediation path is a.hypatia-baseline.json/.hypatia-ignoreexemption — happy to add a grandfathering entry if that's the desired policy call.governance / Check Workflow Staleness— flagsscorecard.ymluploading SARIF without running per-PR;scorecard.ymlis estate-canonical and untouched by this branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01PAEqVP7Y3bZDhtAaPUTbps
Generated by Claude Code