fix(codeql): analyse the languages this repository actually has - #91
Merged
Conversation
`codeql database finalize` was exiting 32 on every run:
CodeQL could not process any code written in JavaScript/TypeScript.
The matrix asserted javascript-typescript, which this repository does not contain.
Its languages are: rust.
This is not only a failing check. The crash uploads no SARIF, so a
`code_scanning` ruleset rule requiring CodeQL waits forever on "Code scanning
is waiting for results from CodeQL" — one fault, two symptoms. Relaxing the
rule's thresholds could not have helped, because no results arrive at all.
New matrix: actions, rust. `actions` is valid in every repository (every
repository has workflow files) and keeps this workflow producing a check and a
SARIF upload even where CodeQL can analyse nothing else — most of this estate
is written in languages CodeQL does not support.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codeql database finalizewas exiting 32 on every run:The matrix asserted
javascript-typescript; this repository's languages arerust. Onecodeql.ymlwas copied estate-wide with a hard-coded JS matrix — 82 repositories carry it, and 17 of the 18 sampled have no JavaScript at all (Julia, Rust, Zig, Agda, Ada, Haskell, Elixir).This is not only a failing check. The crash uploads no SARIF, so a
code_scanningruleset rule requiring CodeQL waits forever on "Code scanning is waiting for results from CodeQL". One fault, two symptoms — and relaxing the rule's thresholds could not have helped, because no results arrive at all.actionsis kept (or added): it is valid in every repository, since every repository has workflow files, and it keeps this workflow producing a check and a SARIF upload even where CodeQL can analyse nothing else.🤖 Generated with Claude Code