Feat/e2e validation tests#47
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
conformance/run_conformance.sh previously built a parser command as a
string and invoked it via `eval "${PARSER}" "$f"`, a
command-injection vector if the caller passes shell metacharacters via
$1.
Fix: build PARSER_CMD as a Bash array, invoke via "${PARSER_CMD[@]}".
No eval, no shell re-parsing. This is the same fix applied across the
nextgen-languages monorepo.
Note: verification/conformance/run_conformance.sh is a symlink to
../conformance/run_conformance.sh, so the verification/ view is
automatically fixed by patching the real path.
Committed on feat/e2e-validation-tests (current branch); will land
on main when the feature branch merges.
Resolves 2 Critical panic-attack CommandInjection findings.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.