Restore first-class Effect semantics for query builders#1
Merged
danieljvdm merged 2 commits intobetafrom Mar 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is the Hyper fork tracking PR for the query-builder Effect semantics fix.
Upstream PR: harrysolovay#2
Problem
During the Effect v4 migration,
applyEffectWrapper()stopped making query builders realEffectvalues at runtime.The types still say these builders are
Effect.Effect<...>, but the wrapper only exposedasEffect()andSymbol.iterator. That leftyield* queryworking while direct Effect combinators on the builder itself stopped working.Broken before this change
At runtime, this regressed because
query.pipewas no longer defined on the builder.The only working forms were the indirect ones:
What this change does
This patch restores first-class
Effectruntime semantics for wrapped query builders.It adds the minimal Effect v4 runtime surface needed for builders to behave like real
Effectvalues again:pipe()Symbol.iteratorexecute()asEffect()is preserved, andcommit()is added as a compatibility alias toexecute().Testing
pnpm --dir drizzle-orm exec vitest run tests/effect-query-effect.test.ts