HW-51714 - Updating gql responses #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion-two-integration' into feature/HW-52170-key-and-field-gql-integration # Conflicts: # ui/src/main/java/com/hyperwallet/android/ui/transfermethod/AddTransferMethodFragment.java
…sion-two-integration' into feature/HW-52170-key-and-field-gql-integration # Conflicts: # ui/src/main/java/com/hyperwallet/android/ui/repository/TransferMethodConfigurationRepositoryImpl.java # ui/src/main/java/com/hyperwallet/android/ui/transfermethod/AddTransferMethodPresenter.java # ui/src/main/java/com/hyperwallet/android/ui/transfermethod/SelectTransferMethodPresenter.java # ui/src/main/java/com/hyperwallet/android/ui/transfermethod/TransferMethodSelectionItem.java # ui/src/test/java/com/hyperwallet/android/ui/transfermethod/AddTransferMethodPresenterTest.java # ui/src/test/java/com/hyperwallet/android/ui/transfermethod/SelectTransferMethodPresenterTest.java
…eld-gql-integration' into task/HW-52045-ui-editability-configuration
* HW-50743 External Account Profile Information * fix for required/non required field can be submitted
* added preset values on widgets * widget-alignment-refactor * finalized margin
…eld-gql-integration' into task/HW-52045-ui-editability-configuration
Closed
…5-ui-editability-configuration' of https://github.com/hyperwallet/hyperwallet-android-ui-sdk into feature/HW-52575-updating-ui-tests
skoong
changed the base branch from
task/HW-52045-ui-editability-configuration
to
epic/HW-52169-gql-version-two-integration
…re/HW-52575-updating-ui-tests' of https://github.com/hyperwallet/hyperwallet-android-ui-sdk into feature/HW-52575-updating-ui-tests
peter-joseph
previously approved these changes
May 21, 2019
fmattos-hw
reviewed
May 21, 2019
| matches(withText(R.string.add_transfer_method_fee_label))); | ||
| onView(withId(R.id.add_transfer_method_processing_label)).check( | ||
| matches(withText(R.string.add_transfer_method_processing_time_label))); | ||
| // onView(withId(R.id.add_transfer_method_processing_label)).check( |
Collaborator
There was a problem hiding this comment.
It would be a good idea adding a "todo" here as it's done in BankAccountTest.java. Also in BankCardTest.java (same test case, testAddTransferMethod_displaysFeeElementsOnTmcResponse) I don't see any changes. Is that test going to fail too, correct? If not I think we missed something there
Collaborator
Author
There was a problem hiding this comment.
Thanks, updated. If a view is has visibility GONE, the value can still be checked and the test will not fail. Added an additional matcher for visibility.
peter-joseph
approved these changes
May 22, 2019
fmattos-hw
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.