HW-52584 receipt list #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' into task/HW-53053-ui-splitted-modules
fmattos-hw
reviewed
Jun 4, 2019
common/src/main/java/com/hyperwallet/android/common/util/DateUtility.java
Outdated
Show resolved
Hide resolved
common/src/test/java/com/hyperwallet/android/common/util/DateUtilityTest.java
Outdated
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/receipt/repository/ReceiptDataSource.java
Outdated
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/receipt/repository/ReceiptDataSource.java
Outdated
Show resolved
Hide resolved
…d-modules' into task/HW-52584-receipt-list # Conflicts: # receipt/src/main/res/values/strings.xml
changed get lifecycle instead of using this
peter-joseph
changed the base branch from
task/HW-53053-ui-splitted-modules
to
development
peter-joseph
changed the base branch from
development
to
task/HW-53053-ui-splitted-modules
receipt/src/main/java/com/hyperwallet/android/receipt/repository/ReceiptDataSourceFactory.java
Outdated
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/receipt/view/ListReceiptFragment.java
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/receipt/view/ListReceiptFragment.java
Show resolved
Hide resolved
added 2 commits
June 6, 2019 07:54
fmattos-hw
reviewed
Jun 6, 2019
fmattos-hw
requested changes
Jun 6, 2019
common/src/main/java/com/hyperwallet/android/common/util/DateUtils.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/hyperwallet/android/common/util/DateUtils.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/hyperwallet/android/common/viewmodel/Event.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/hyperwallet/android/common/viewmodel/Event.java
Show resolved
Hide resolved
receipt/src/test/java/com/hyperwallet/android/receipt/repository/ReceiptDataSourceTest.java
Outdated
Show resolved
Hide resolved
receipt/src/test/java/com/hyperwallet/android/receipt/repository/ReceiptDataSourceTest.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/repository/TransferMethodRepositoryImpl.java
Show resolved
Hide resolved
skoong
reviewed
Jun 7, 2019
receipt/src/main/java/com/hyperwallet/android/receipt/repository/ReceiptRepositoryImpl.java
Show resolved
Hide resolved
added 2 commits
June 10, 2019 08:34
fmattos-hw
requested changes
Jun 10, 2019
Collaborator
fmattos-hw
left a comment
fmattos-hw
left a comment
There was a problem hiding this comment.
Almost there, well done! Just a few more things
- ReceiptDataSourceTest#testRetry_LoadAfter is still with L upper case
- ListReceiptActivity#showErrorOnLoadReceipt can be private
added 2 commits
June 10, 2019 15:55
azakrevska-epam
previously approved these changes
Jun 11, 2019
fmattos-hw
previously approved these changes
Jun 11, 2019
fmattos-hw
approved these changes
Jun 11, 2019
skoong
approved these changes
Jun 11, 2019
vshcherbyna-epam
pushed a commit
that referenced
this pull request
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.