task/HW-54230 renamed ui #67
Conversation
…r-method-repository-module
…r-method-repository-module
# Conflicts: # receipt/src/test/java/com/hyperwallet/android/ui/rule/HyperwalletExternalResourceManager.java # receiptrepository/src/test/java/com/hyperwallet/android/ui/rule/HyperwalletExternalResourceManager.java # receiptui/src/test/java/com/hyperwallet/android/ui/transfermethod/rule/HyperwalletExternalResourceManager.java # settings.gradle # transfermethodrepository/src/main/java/com/hyperwallet/android/ui/transfermethod/repository/TransferMethodConfigurationRepositoryImpl.java # transfermethodui/build.gradle # transfermethodui/src/main/java/com/hyperwallet/android/ui/transfermethod/repository/UserRepository.java # transfermethodui/src/main/java/com/hyperwallet/android/ui/transfermethod/repository/UserRepositoryImpl.java # transfermethodui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/AddTransferMethodFragment.java # transfermethodui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/SelectTransferMethodFragment.java # transfermethodui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/SelectTransferMethodPresenter.java # transfermethodui/src/test/java/com/hyperwallet/android/ui/transfermethod/AddTransferMethodPresenterTest.java # transfermethodui/src/test/java/com/hyperwallet/android/ui/transfermethod/ListTransferMethodPresenterTest.java # transfermethodui/src/test/java/com/hyperwallet/android/ui/transfermethod/SelectTransferMethodPresenterTest.java # transfermethodui/src/test/java/com/hyperwallet/android/ui/transfermethod/repository/UserRepositoryImplTest.java # ui/src/main/java/com/hyperwallet/android/ui/repository/UserRepository.java # ui/src/main/java/com/hyperwallet/android/ui/repository/UserRepositoryImpl.java # ui/src/test/java/com/hyperwallet/android/ui/repository/UserRepositoryImplTest.java # userrepository/src/main/java/com/hyperwallet/android/ui/user/repository/UserRepository.java # userrepository/src/main/java/com/hyperwallet/android/ui/user/repository/UserRepositoryImpl.java # userrepository/src/test/java/com/hyperwallet/android/ui/user/repository/UserRepositoryImplTest.java
fmattos-hw
requested review from
azakrevska-epam,
peter-joseph,
skoong and
vshcherbyna-epam
| implementation "com.google.android.material:material:$androidMaterialVersion" | ||
| implementation "com.hyperwallet.android:core-sdk:$hyperwalletCoreVersion" | ||
|
|
||
| api "com.hyperwallet.android:core-sdk:$hyperwalletCoreVersion" |
There was a problem hiding this comment.
Could we use implementation here?
In this case all APIs from the core will be accessible through the ui module when vendor implements ui-sdk.
It will look ambiguous. @fmattos-hw @peter-joseph Could you add your thoughts here.
There was a problem hiding this comment.
Im good with api since thats exactly what we are trying to do, please refer to api vs. implementation document, 1 quick example of this is that our sdk core models and constants can be easily accessible in consuming app (like demo app)
| implementation "com.google.android.material:material:$androidMaterialVersion" | ||
| implementation "com.hyperwallet.android:core-sdk:$hyperwalletCoreVersion" | ||
|
|
||
| api "com.hyperwallet.android:core-sdk:$hyperwalletCoreVersion" |
There was a problem hiding this comment.
Im good with api since thats exactly what we are trying to do, please refer to api vs. implementation document, 1 quick example of this is that our sdk core models and constants can be easily accessible in consuming app (like demo app)
| @@ -0,0 +1,82 @@ | |||
| apply plugin: 'jacoco' | |||
|
|
|||
| final def jacocoVersion = "0.8.2" | |||
There was a problem hiding this comment.
Hmm, can we have a consistent declaration of props in root directory? (when I searched jacocoVersion it seems that its been defined in all modules), can we add it to hyperwallet-android-ui-sdk/build.gradle ?
No description provided.