task/HW-54230 renamed ui #67
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,4 +16,9 @@ local.properties | |
| *.log | ||
|
|
||
| # Android Studio captures folder | ||
| captures/ | ||
|
|
||
|
|
||
| *.exec | ||
|
|
||
| *.hprof | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| apply plugin: 'jacoco' | ||
|
|
||
| final def jacocoVersion = "0.8.2" | ||
|
Collaborator
There was a problem hiding this comment. Hmm, can we have a consistent declaration of props in root directory? (when I searched |
||
|
|
||
| jacoco { | ||
| toolVersion = jacocoVersion | ||
| } | ||
|
|
||
| android { | ||
| testOptions { | ||
| unitTests { | ||
| includeAndroidResources = true | ||
| returnDefaultValues = true | ||
| } | ||
| unitTests.all { | ||
| jacoco { | ||
| includeNoLocationClasses = true | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| def fileFilter = ['**/BuildConfig.*', | ||
| '**/com/hyperwallet/android/ui/common/repository/EspressoIdlingResource.*', | ||
| '**/com/hyperwallet/android/ui/common/repository/Event.*' | ||
| ] | ||
|
|
||
| def debugClassPaths = [ | ||
| '**/intermediates/javac/debug/*/classes/**' | ||
| ] | ||
|
|
||
| final def coverageSourceDirs = ["$project.projectDir/src/main/java/*"] | ||
|
|
||
| task jacocoTestReport(type: JacocoReport, dependsOn: 'testDebugUnitTest') { | ||
|
|
||
| group = 'Reporting' | ||
| description = 'Generate Jacoco coverage reports.' | ||
|
|
||
| reports { | ||
| html { | ||
| enabled = true | ||
| destination file("$buildDir/reports/jacoco") | ||
| } | ||
| } | ||
|
|
||
| classDirectories = fileTree( | ||
| dir: "${buildDir}", | ||
| includes: debugClassPaths, | ||
| excludes: fileFilter | ||
| ) | ||
|
|
||
| additionalSourceDirs = files(coverageSourceDirs) | ||
| sourceDirectories = files(coverageSourceDirs) | ||
| executionData = files("${buildDir}/jacoco/testDebugUnitTest.exec") | ||
| } | ||
|
|
||
| task jacocoTestCoverageVerification(type: JacocoCoverageVerification, dependsOn: 'jacocoTestReport') { | ||
|
|
||
| group = 'Verification' | ||
| classDirectories = fileTree( | ||
| dir: "${buildDir}", | ||
| includes: debugClassPaths, | ||
| excludes: fileFilter | ||
| ) | ||
| additionalSourceDirs = files(coverageSourceDirs) | ||
| sourceDirectories = files(coverageSourceDirs) | ||
| executionData = files("${buildDir}/jacoco/testDebugUnitTest.exec") | ||
|
|
||
| violationRules { | ||
| setFailOnViolation(true) | ||
|
|
||
| rule { | ||
| element = 'CLASS' | ||
| limit { | ||
| value = 'COVEREDRATIO' | ||
| counter = 'BRANCH' | ||
| minimum = 0.65 | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| <manifest package="com.hyperwallet.android.common" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| apply from: "$rootProject.projectDir/android-library.gradle" | ||
| apply from: "$rootProject.projectDir/publish.gradle" | ||
|
|
||
| dependencies { | ||
| implementation project(':commonrepository') | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <lint> | ||
| <issue id="VectorPath" severity="ignore"/> | ||
| <issue id="RtlEnabled"> | ||
| <ignore regexp="(AndroidManifest).xml"/> | ||
| </issue> | ||
| </lint> |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use
implementationhere?In this case all APIs from the
corewill be accessible through theuimodule when vendor implements ui-sdk.It will look ambiguous. @fmattos-hw @peter-joseph Could you add your thoughts here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im good with
apisince thats exactly what we are trying to do, please refer to api vs. implementation document, 1 quick example of this is that our sdk core models and constants can be easily accessible in consuming app (like demo app)