Updates to IncomingHttpRequest #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbach
force-pushed
the
wg/incoming_http_updates
branch
from
6326617 to
e14f212
Compare
dr-frmr
suggested changes
Feb 15, 2024
src/http.rs
Outdated
Comment on lines
238
to
242
| pub fn bound_path(&self, strip_prefix: Option<&str>) -> String { | ||
| self.bound_path | ||
| .replace(strip_prefix.unwrap_or(""), "") | ||
| .replace("//", "/") | ||
| } |
Contributor
There was a problem hiding this comment.
can you please add a docstring here that describes what's going on? i'm confused, so likely others using this function will be too
dr-frmr
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, it is possible to bind an HTTP path in
http_serverwith a URL param like/test/:test-id, but it is not possible to get easy access to:test-idor the path that was originally bound.Solution
This PR includes the updates to the IncomingHttpRequest, along with additional methods for parsing the
bound_pathDocs Update
Corresponding docs PR
Notes
There will be a repo added that can be used to test http bindings and requests.