Skip to content

feat(gateway): add support for connecting to other gateways#158

Merged
orlandohohmeier merged 1 commit intoalphafrom
orlandohohmeier/fault-tollerant-gateway
Nov 28, 2025
Merged

feat(gateway): add support for connecting to other gateways#158
orlandohohmeier merged 1 commit intoalphafrom
orlandohohmeier/fault-tollerant-gateway

Conversation

@orlandohohmeier
Copy link
Contributor

Gateways can now connect to other gateways for network entry, similar to how workers and schedulers connect. The gateway attempts to connect to all provided gateway addresses during startup. By deploying more than one gateway and connecting them together, one can improve the systems reliability.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@orlandohohmeier orlandohohmeier requested a review from l45k November 25, 2025 19:12
@orlandohohmeier orlandohohmeier force-pushed the orlandohohmeier/fault-tollerant-gateway branch from f628cd5 to d97eeef Compare November 25, 2025 19:13
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/gateway/src/bin/hypha-gateway.rs 0.00% 19 Missing ⚠️
crates/gateway/src/config.rs 0.00% 14 Missing ⚠️

📢 Thoughts on this report? Let us know!

Gateways can now connect to other gateways for network entry, similar to how workers and schedulers connect. The gateway attempts to connect to all provided gateway addresses during startup. By deploying more than one gateway and connecting them together, one can improve the systems reliability.

Co-Authored-By: Claude <noreply@anthropic.com>
@orlandohohmeier orlandohohmeier force-pushed the orlandohohmeier/fault-tollerant-gateway branch from d97eeef to 63bf2ad Compare November 26, 2025 07:58
@l45k
Copy link
Contributor

l45k commented Nov 28, 2025

I tested the change and it partially worked. I was able to start two gateway. One with a public IP and one within a private environment. The data node was connected to the first gateway and all workers to the second. The gateways connected as expected. However, I ran into a relayed connection issue which finally resulted in an error on the parameter server. I might have just missconfigured something.

Copy link
Contributor

@l45k l45k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #176 merged the error still occures, but the retry is successful and the process continues. My understanding, we first use a relayed connection and once this is closed we are able to create a direct connection. Interessting is that this can take somehow longer. I see two errors in the logs. Thus, the first attempt isn't succesful.

@orlandohohmeier orlandohohmeier merged commit d176c5e into alpha Nov 28, 2025
8 of 9 checks passed
@orlandohohmeier orlandohohmeier deleted the orlandohohmeier/fault-tollerant-gateway branch November 28, 2025 10:04
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-alpha.22 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants