Skip to content

feat: partial retry#176

Merged
l45k merged 1 commit intoalphafrom
leo/retry
Nov 28, 2025
Merged

feat: partial retry#176
l45k merged 1 commit intoalphafrom
leo/retry

Conversation

@l45k
Copy link
Contributor

@l45k l45k commented Nov 28, 2025

This change introduces retries on the bridge and parameter server. Retries are applied on progress request/respponse messages, on send and fetch. Since it is hard to implement a retry on a receive, we only implement it in sends and receives should therefore also be covered.

@l45k l45k requested a review from orlandohohmeier November 28, 2025 09:12
This change introduces retries on the bridge and parameter server.
Retries are applied on progress request/respponse messages, on send and
fetch. Since it is hard to implement a retry on a receive, we only
implement it in sends and receives should therefore also be covered.
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 0% with 133 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/worker/src/executor/bridge.rs 0.00% 83 Missing ⚠️
crates/worker/src/executor/parameter_server.rs 0.00% 44 Missing ⚠️
crates/scheduler/src/metrics_bridge.rs 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@orlandohohmeier orlandohohmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may actually help with the issues I see in my current worker pool implementation.

@l45k l45k merged commit 6e2ddc2 into alpha Nov 28, 2025
8 of 9 checks passed
@l45k l45k deleted the leo/retry branch November 28, 2025 09:47
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-alpha.21 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants